From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c
Date: Sun, 11 Mar 2012 03:35:45 -0400 [thread overview]
Message-ID: <201203110335.47070.vapier@gentoo.org> (raw)
In-Reply-To: <CALButC+SE8BisjFfujWh1vyf17ACy_RVBXuit8PqTXdDZnQB+w@mail.gmail.com>
On Wednesday 07 March 2012 00:50:15 Graeme Russ wrote:
> On Wed, Mar 7, 2012 at 3:20 AM, Mike Frysinger wrote:
> > On Tuesday 06 March 2012 01:34:24 Simon Glass wrote:
> >> On Mon, Mar 5, 2012 at 9:05 PM, Mike Frysinger wrote:
> >> > On Monday 20 February 2012 20:32:47 Simon Glass wrote:
> >> >> These basic functions are needed by relocation. To avoid bringing in
> >> >> all string.c functions (and the resulting code bloat for
> >> >> architectures where -ffunction-sections is not used), move these
> >> >> into their own file.
> >> >
> >> > seems like fixing -f{data,function}-sections would be a more useful
> >> > goal. i don't know why arm doesn't support this today ... it's fairly
> >> > easy to do.
> >>
> >> I did enable it for Tegra at one point with no ill effects except for
> >> breaking warmboot, which relied on function ordering. I notice the
> >> no-toplevel-reorder flag on x86 but not with ARM. But I assumed there
> >> must be some reason it is not used and thought this patch safer, since
> >> it is just a minor tweak on a series that has has some review.
> >
> > if we keep assuming that, then it'll never get fixed, and we'll sit on a
> > steady stream of "small safe patches". plus, fixing this yields general
> > improvements in anti-bloat for everyone.
> >
> > function ordering sounds like something that should be imposed at the
> > linker level ... for Blackfin, all i had to care about was the entry
> > point was at the start of the .text, although warmbooting is fairly low
> > level magic, and i handle that in the SPL-like core.
>
> Can't the entry point be forced to be at the start of the u-boot image by
> putting that function in a dedicated section and specifying that section
> as the first in the linker script?
yes ... that's what Blackfin does:
...
ENTRY(_start)
SECTIONS
{
.text.pre :
{
arch/blackfin/cpu/start.o (.text .text.*)
...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120311/7206a6f7/attachment.pgp>
next prev parent reply other threads:[~2012-03-11 7:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 1:32 [U-Boot] [PATCH v4 0/13] Introduce generic relocation feature Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 01/13] Define CONFIG_SYS_SKIP_RELOC for all archs Simon Glass
2012-03-06 5:04 ` Mike Frysinger
2012-03-06 6:27 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 02/13] Add generic relocation feature Simon Glass
2012-02-21 19:36 ` Albert ARIBAUD
2012-02-21 20:03 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 03/13] arm: Export and promote relocation symbols Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 04/13] arm: Add start_call_board_init_r() to each start.S Simon Glass
2012-02-21 19:32 ` Albert ARIBAUD
2012-02-21 20:02 ` Simon Glass
2012-02-23 13:07 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c Simon Glass
2012-03-06 5:05 ` Mike Frysinger
2012-03-06 6:34 ` Simon Glass
2012-03-06 16:20 ` Mike Frysinger
2012-03-07 5:43 ` Simon Glass
2012-03-07 5:50 ` Graeme Russ
2012-03-07 17:48 ` Simon Glass
2012-03-11 7:35 ` Mike Frysinger [this message]
2012-02-21 1:32 ` [U-Boot] [PATCH v4 06/13] arm: Add explicit __image_copy_end symbol for ARM926EJ-S Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 07/13] davinci: Use correct #ifdef around gdata/bdata Simon Glass
2012-02-21 15:24 ` Tom Rini
2012-02-23 17:25 ` Sughosh Ganu
2012-02-26 17:56 ` Simon Glass
2012-02-27 10:16 ` Sughosh Ganu
2012-02-27 10:39 ` Christian Riesch
2012-02-27 10:56 ` Sughosh Ganu
2012-02-27 11:37 ` Christian Riesch
2012-02-27 12:02 ` Sughosh Ganu
2012-02-28 21:55 ` Albert ARIBAUD
2012-02-28 22:03 ` Scott Wood
2012-03-03 20:22 ` Simon Glass
2012-03-03 20:29 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 08/13] tx25: Modify to work with generic relocation Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 09/13] hawkboard: " Simon Glass
2012-02-21 15:25 ` Tom Rini
2012-02-23 8:43 ` Sughosh Ganu
2012-02-23 15:11 ` Sughosh Ganu
2012-02-26 18:09 ` Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 10/13] mx31pdk: " Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 11/13] smdk6400: " Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 12/13] arm: Move over to " Simon Glass
2012-02-21 1:32 ` [U-Boot] [PATCH v4 13/13] arm: Remove unused code in start.S Simon Glass
2012-02-21 19:40 ` [U-Boot] [PATCH v4 0/13] Introduce generic relocation feature Albert ARIBAUD
2012-02-21 20:07 ` Simon Glass
2012-02-21 20:10 ` Graeme Russ
2012-02-21 20:16 ` Simon Glass
[not found] ` <4F4D4511.6020708@aribaud.net>
2012-03-03 16:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203110335.47070.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox