[U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage

[Mike Frysinger <vapier@gentoo.org>]

On Monday 12 March 2012 17:34:21 Marek Vasut wrote:
>  common/Makefile    |    1 +
>  common/cmd_bootm.c |   29 +--------
>  common/cmd_bootz.c |  175
>  include/image.h    |    8 +++

new commands should be in include/config_cmd_all.h and the top level README

> --- /dev/null
> +++ b/common/cmd_bootz.c
>
> + * Copyright (C) 2011 Marek Vasut <marek.vasut@gmail.com>

it's 2012 now

> +#include <watchdog.h>
> +#include <malloc.h>
> +#include <u-boot/zlib.h>
> +#include <bzlib.h>
> +#include <environment.h>
> +#include <linux/ctype.h>
> +#include <asm/byteorder.h>
> +#if defined(CONFIG_SYS_HUSH_PARSER)
> +#include <hush.h>
> +#endif

seems like these are all unused

> +#define IH_INITRD_ARCH IH_ARCH_DEFAULT

this gets used in one place.  just inline its usage

> +extern int do_bootm_linux(int flag, int argc, char * const argv[],
> +			bootm_headers_t *images);

should get moved to include/command.h instead of copying it to more places

> --- a/common/image.c
> +++ b/common/image.c
>
> +#ifdef	CONFIG_LMB

should be a space after #ifdef, not a tab

> +void __arch_preboot_os(void)

static
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120312/56d7bd6e/attachment.pgp>