public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage
Date: Tue, 13 Mar 2012 01:13:18 +0100	[thread overview]
Message-ID: <201203130113.19092.marex@denx.de> (raw)
In-Reply-To: <20120312224255.5FD0F202F14@gemini.denx.de>

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> btw - there is no need to full-quote.
> 
> In message <201203122308.54249.marex@denx.de> you wrote:
> > > I have but a few formal questions / issues.
> > 
> > I had a dilemma about the image.[ch] indeed. I was quite unsure where to
> > put those, can you suggest proper location? I didn't want to create new
> > file only for that matter.
> 
> Sorry, I have no good idea either.
> 
> If you omit comment header and includes, common/cmd_bootz.c adds less
> than 10% to common/cmd_bootm.c - unless we extrace more common code
> from other boot* commands, you might even add it to cmd_bootm.c (with
> #ifdef's).
> 
> 
> While we are at it:
> 
> +	zi = (struct zimage_header *)images->ep;
> +
> +	if (zi->zi_magic != LINUX_ARM_ZIMAGE_MAGIC) {

This gave me an idea ... this might be how to check for zImage inside bootm and 
be done with it. Simply squash those two together.

> 
> Do we have to care about endianess here?

We should make bootz arm-specific until more people (with different arches) step 
up and verify it works for them.

> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut

  reply	other threads:[~2012-03-13  0:13 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Message-Id: <1331588061-21546-1-git-send-email-marex@denx.de>
2012-03-12 21:34 ` [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage Marek Vasut
2012-03-12 22:03   ` Wolfgang Denk
2012-03-12 22:08     ` Marek Vasut
2012-03-12 22:42       ` Wolfgang Denk
2012-03-13  0:13         ` Marek Vasut [this message]
2012-03-13  0:22           ` Graeme Russ
2012-03-13  4:30             ` Wolfgang Denk
2012-03-13  4:46               ` Graeme Russ
2012-03-15 15:03                 ` Wolfgang Denk
2012-03-15 17:08                   ` Marek Vasut
2012-03-13  4:47               ` Marek Vasut
2012-03-15 15:06                 ` Wolfgang Denk
2012-03-15 17:18                   ` Marek Vasut
2012-03-13  4:25           ` Wolfgang Denk
2012-03-13  4:50             ` Marek Vasut
2012-03-13  5:32               ` Graeme Russ
2012-03-13  2:03   ` Mike Frysinger
2012-03-14  1:38 ` [U-Boot] [PATCH V4] BOOT: Add "bootz" command to boot Linux zImage on ARM Marek Vasut
2012-03-14  2:03   ` Mike Frysinger
2012-03-14  2:40     ` Marek Vasut
2012-03-14  3:07       ` Mike Frysinger
     [not found] <Message-Id: <1331689093-19211-1-git-send-email-marex@denx.de>
2012-03-14  3:47 ` [U-Boot] [PATCH V5] " Marek Vasut
2012-03-14  5:07   ` Mike Frysinger
2012-03-14  5:38     ` Marek Vasut
2012-03-14 18:35       ` Mike Frysinger
2012-03-14 19:27         ` Marek Vasut
2012-03-15 16:09       ` Wolfgang Denk
2012-03-15 17:08         ` Marek Vasut
2012-03-15 17:36         ` Mike Frysinger
2012-03-15 17:40           ` Marek Vasut
2012-03-14 16:45   ` Stephen Warren
2012-03-14 17:23     ` Marek Vasut
     [not found] <Message-Id: <1331696876-20903-1-git-send-email-marex@denx.de>
2012-03-15  7:52 ` [U-Boot] [PATCH V6] " Marek Vasut
2012-03-15 18:51   ` Rob Herring
2012-03-15 19:05     ` Marek Vasut
2012-03-15 19:48       ` Rob Herring
2012-03-15 20:29         ` Marek Vasut
2012-03-15 21:10           ` Rob Herring
2012-03-15 22:02             ` Rob Herring
2012-03-16  0:53               ` Marek Vasut
2012-03-16  7:16               ` Wolfgang Denk
2012-03-16 18:20                 ` Rob Herring
2012-03-15 20:39         ` Wolfgang Denk
2012-03-30 20:59   ` Wolfgang Denk
2012-03-31 19:10   ` Mike Frysinger
2012-03-31 19:27     ` Marek Vasut
2012-04-01 11:25       ` Graeme Russ
2012-04-01 14:02         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203130113.19092.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox