public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/27] Create generic board init for ARM, x86, PPC
Date: Fri, 16 Mar 2012 13:07:23 -0700	[thread overview]
Message-ID: <20120316200723.GD31661@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ1oTUBa4mH2u6jM3_EQ3jJecyfK6B17myP8SKShMUVvPQ@mail.gmail.com>

On Fri, Mar 16, 2012 at 12:34:20PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, Mar 16, 2012 at 12:23 PM, Tom Rini <trini@ti.com> wrote:
> > On Wed, Mar 14, 2012 at 07:15:57PM -0700, Simon Glass wrote:
> >
> >> This series creates a generic board.c implementation which contains
> >> the essential functions of the major arch/xxx/lib/board.c files.
> >
> > Let me start by saying that I agree with the premise, please read any
> > inflection/tone as that of someone trying to debug a problem only :)
> 
> Understood :-)
> 
> >
> > I'm trying to test this on omap4_panda right now and I'm running into a
> > problem where we hang setting up gd->bd->bi_dram[0]. ?I don't see why
> > this isn't being set (some quick peeking around and SPL is behaving
> > normally and doing its configure of DRAM and so forth). ?But I also
> > can't debug this problem as easily as I would like because:
> > (a) despite DEBUG being defined, none of the debug() prints are printing
> > (my printf's are)
> 
> There is only one macro that affects that - make sure #define DEBUG is
> above #include common.h or maybe just change them to printf() to work
> this out...

I've gone and changed them to printf's, and a lot of stuff I would
expect to see, I don't.  On tegra, can you do a before/after debug build
and see what board_init_f shows?

> > (b) I assume this is because there's so much reconciliation needed
> > still, but the file is an unwieldy mess. ?In fact, as I'm writing this
> > and debugging at the same time, it seems reserve_board isn't being
> > called, but it's compiled in, in the non-SPL case. ?I'm not seeing
> > what's up...
> 
> I split out the SPL stuff because it wasn't exactly clear to me what
> was different between SPL and normal start-up. Only recently did I get
> a board that supports SPL, and I was planning on looking at this soon.
> I can't give any specific guidance other than persistence and good
> debug tools :-)

Actually, what I'm seeing is more "is this generic or ARM or x86 or PPC
code?"  There's a lot of that merging that needs doing still and I guess
that's part of the mess.

> But please do let me know how you get on, and thanks for looking at
> it. This effort is worthy but not easy.

I'll post patches for omap4_panda and then hopefully omap3_beagle, or
die trying :)

-- 
Tom

  reply	other threads:[~2012-03-16 20:07 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  2:15 [U-Boot] [PATCH v4 0/27] Create generic board init for ARM, x86, PPC Simon Glass
2012-03-15  2:15 ` [U-Boot] [PATCH v4 01/27] arm: Change board baud_rate to ulong Simon Glass
2012-03-15  2:15 ` [U-Boot] [PATCH v4 02/27] x86: " Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 03/27] arm: Only display frame buffer info if there is LCD/video support Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 04/27] x86: Remove dead code in eNET Simon Glass
2012-03-15  2:27   ` Graeme Russ
2012-03-15  2:28     ` Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 05/27] x86: Add initial memory barrier macros Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 06/27] ppc: " Simon Glass
2012-03-15 17:56   ` Scott Wood
2012-03-15  2:16 ` [U-Boot] [PATCH v4 07/27] Introduce generic global_data Simon Glass
2012-03-15  2:30   ` Graeme Russ
2012-03-15  2:35   ` Graeme Russ
2012-03-15  2:50     ` Simon Glass
2012-03-15  3:02       ` Graeme Russ
2012-03-15  3:41         ` Simon Glass
2012-03-24  6:40           ` Simon Glass
2012-03-24 11:14             ` Graeme Russ
2012-03-24 23:10               ` Simon Glass
2012-03-24 23:54                 ` Graeme Russ
2012-03-15  2:16 ` [U-Boot] [PATCH v4 08/27] Introduce generic u-boot.h file Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 09/27] Introduce generic link section.h symbol files Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 10/27] arm: Use sections header to obtain link symbols Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 11/27] x86: Change stub example to use asm-generic/sections.h Simon Glass
2012-03-15  2:29   ` Graeme Russ
2012-03-15  2:44     ` Simon Glass
2012-03-15  2:48       ` Graeme Russ
2012-03-15  2:16 ` [U-Boot] [PATCH v4 12/27] Introduce a basic initcall implementation Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 13/27] Define CONFIG_SYS_LEGACY_BOARD everywhere Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 14/27] Introduce generic pre-relocation board_f.c Simon Glass
2012-03-15 19:09   ` Scott Wood
2012-03-15 21:23     ` Simon Glass
2012-03-15 21:25       ` Scott Wood
2012-03-16  5:31       ` Wolfgang Denk
2012-03-15  2:16 ` [U-Boot] [PATCH v4 15/27] Introduce generic post-relocation board_r.c Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 16/27] Add spl load feature Simon Glass
2012-03-15 19:29   ` Scott Wood
2012-03-15  2:16 ` [U-Boot] [PATCH v4 17/27] arm: Enable generic board support Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 18/27] Add CONFIG_SYS_SYM_OFFSETS to support offset symbols Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 19/27] x86: Use sections header to obtain link symbols Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 20/27] Add x86 fields to generic global_data Simon Glass
2012-03-15  2:36   ` Graeme Russ
2012-03-15  2:54     ` Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 21/27] x86: Enable generic board support Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 22/27] Add ppc fields to generic global data Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 23/27] Adjust board_f for ppc Simon Glass
2012-03-15 19:12   ` Scott Wood
2012-03-15 21:25     ` Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 24/27] Adjust board_r.c for PowerPC Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 25/27] ppc: Enable generic board board Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 26/27] tegra: Mark board init files for ARMv4t Simon Glass
2012-03-15  2:16 ` [U-Boot] [PATCH v4 27/27] tegra: Enable generic board for Seaboard Simon Glass
2012-03-16 19:23 ` [U-Boot] [PATCH v4 0/27] Create generic board init for ARM, x86, PPC Tom Rini
2012-03-16 19:34   ` Simon Glass
2012-03-16 20:07     ` Tom Rini [this message]
2012-03-16 21:53       ` Tom Rini
2012-03-16 22:19         ` Simon Glass
2012-03-16 22:26           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120316200723.GD31661@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox