public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] add new board nas62x0
Date: Sun, 18 Mar 2012 11:04:28 +0100	[thread overview]
Message-ID: <20120318100428.ADC28202BB3@gemini.denx.de> (raw)
In-Reply-To: <20120317234054.GA21334@w500.lan>

Dear Luka Perkov,

In message <20120317234054.GA21334@w500.lan> you wrote:
>
> Add support for new boards RaidSonic ICY BOX NAS6210 and NAS6220 boards.

Just a tiny detail...

...
> +/*
> + * Version number information
> + */
> +#ifdef CONFIG_BOARD_IS_IB_NAS6210
> +# define CONFIG_IDENT_STRING	" RaidSonic ICY BOX IB-NAS6210"
> +#elif CONFIG_BOARD_IS_IB_NAS6220

For robustness, this should rather be

	#elif defined(CONFIG_BOARD_IS_IB_NAS6220)

[and for consistency, you then may want to reqrite the #if above as

	#if defined(CONFIG_BOARD_IS_IB_NAS6210)

]

Thanks!


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I often quote myself; it adds spice to my conversation.  - G. B. Shaw

  parent reply	other threads:[~2012-03-18 10:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-17 23:40 [U-Boot] [PATCH v2] add new board nas62x0 Luka Perkov
2012-03-17 23:43 ` Luka Perkov
2012-03-18 10:04 ` Wolfgang Denk [this message]
2012-03-18 15:15 ` Marek Vasut
2012-03-18 18:31   ` Luka Perkov
2012-03-19 15:50     ` Marek Vasut
2012-03-19 22:42       ` Luka Perkov
2012-03-20  6:48         ` Marek Vasut
2012-03-21  0:34           ` Luka Perkov
2012-03-21  7:21             ` Marek Vasut
2012-03-21  9:51               ` Prafulla Wadaskar
2012-03-21 10:02                 ` Marek Vasut
2012-03-21 10:15                   ` Prafulla Wadaskar
2012-03-21 10:56                     ` Marek Vasut
2012-03-21 12:01                       ` Prafulla Wadaskar
2012-03-20  7:04       ` DrEagle
2012-03-20  8:21         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120318100428.ADC28202BB3@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox