public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] cmd_fat: add FAT write command
Date: Sun, 18 Mar 2012 22:04:08 +0100	[thread overview]
Message-ID: <20120318210408.1EC67202D7F@gemini.denx.de> (raw)
In-Reply-To: <1331632670-14874-1-git-send-email-mvs@tigris.de>

Dear Maximilian,

In message <1331632670-14874-1-git-send-email-mvs@tigris.de> you wrote:
> From: Donggeun Kim <dg77.kim at>
> 
> Once CONFIG_FAT_WRITE is defined,
> users can invoke 'fatwrite' command that saves data in RAM as a FAT file.

Thanks for picking up this patch. A few minor comments:

Please add documentation for the new CONFIG_FAT_WRITE config option to
the top level README.


> This patch also removes compile error after patch of
> 'fs/fat: Fix FAT detection to support non-DOS partition tables'.

Which compile error would that be?  I am not aware of any such error.

If ther eis one, the fix should be in a separate patch;  otherwise
this comment should be removed.

Thanks!

  parent reply	other threads:[~2012-03-18 21:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  9:57 [U-Boot] [PATCH 1/2] cmd_fat: add FAT write command Maximilian Schwerin
2012-03-13  9:57 ` [U-Boot] [PATCH 2/2] Add support for loading and saving the environment to a FAT partition Maximilian Schwerin
2012-03-30 20:40   ` Wolfgang Denk
2012-03-18 21:04 ` Wolfgang Denk [this message]
2012-03-22 14:38 ` [U-Boot] [PATCH 1/2] FAT write: Fix compile errors Maximilian Schwerin
2012-03-24 23:57   ` [U-Boot] [PATCH] fs/fat/fat_write.c: Fix GCC 4.6 warnings Anatolij Gustschin
2012-03-25  0:30     ` Anatolij Gustschin
2012-03-25  0:17   ` [U-Boot] [PATCH 1/2] FAT write: Fix compile errors Anatolij Gustschin
2012-03-22 14:38 ` [U-Boot] [PATCH 2/2] cmd_fat: add FAT write command Maximilian Schwerin
2012-03-25  0:26   ` Anatolij Gustschin
2012-03-26  0:34     ` Kyungmin Park
2012-03-26  7:13       ` Anatolij Gustschin
2012-03-26  8:27         ` Maximilian Schwerin
2012-03-26  8:33         ` Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120318210408.1EC67202D7F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox