* [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator
@ 2012-03-17 2:41 Marek Vasut
2012-03-18 23:34 ` Linus Walleij
2012-11-03 9:11 ` [U-Boot] [PATCH V2] " Marek Vasut
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2012-03-17 2:41 UTC (permalink / raw)
To: u-boot
These boards couldn't save their environment because they couldn't malloc()
the whole size of the sector.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
include/configs/integratorcp.h | 2 +-
include/configs/versatile.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/configs/integratorcp.h b/include/configs/integratorcp.h
index 57610a6..511fa1f 100644
--- a/include/configs/integratorcp.h
+++ b/include/configs/integratorcp.h
@@ -56,7 +56,7 @@
/*
* Size of malloc() pool
*/
-#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128*1024)
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128*1024)
/*
* Hardware drivers
diff --git a/include/configs/versatile.h b/include/configs/versatile.h
index bb835e0..6a9aa30 100644
--- a/include/configs/versatile.h
+++ b/include/configs/versatile.h
@@ -71,7 +71,7 @@
* Size of malloc() pool
*/
#define CONFIG_ENV_SIZE 8192
-#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128 * 1024)
/*
* Hardware drivers
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator
2012-03-17 2:41 [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator Marek Vasut
@ 2012-03-18 23:34 ` Linus Walleij
2012-03-18 23:37 ` Marek Vasut
2012-11-03 9:11 ` [U-Boot] [PATCH V2] " Marek Vasut
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2012-03-18 23:34 UTC (permalink / raw)
To: u-boot
On Sat, Mar 17, 2012 at 3:41 AM, Marek Vasut <marex@denx.de> wrote:
> These boards couldn't save their environment because they couldn't malloc()
> the whole size of the sector.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator
2012-03-18 23:34 ` Linus Walleij
@ 2012-03-18 23:37 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2012-03-18 23:37 UTC (permalink / raw)
To: u-boot
Dear Linus Walleij,
> On Sat, Mar 17, 2012 at 3:41 AM, Marek Vasut <marex@denx.de> wrote:
> > These boards couldn't save their environment because they couldn't
> > malloc() the whole size of the sector.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
>
> Thanks!
> Linus Walleij
You're welcome, we're now running daily u-boot tests on qemulated integrator ;-)
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V2] ARM: Fix malloc area size for versatile and integrator
2012-03-17 2:41 [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator Marek Vasut
2012-03-18 23:34 ` Linus Walleij
@ 2012-11-03 9:11 ` Marek Vasut
2013-02-02 23:35 ` Albert ARIBAUD
1 sibling, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2012-11-03 9:11 UTC (permalink / raw)
To: u-boot
These boards couldn't save their environment because they couldn't malloc()
the whole size of the sector.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
---
include/configs/integrator-common.h | 3 ++-
include/configs/versatile.h | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
V2: Align with current code
diff --git a/include/configs/integrator-common.h b/include/configs/integrator-common.h
index 564b418..51227e7 100644
--- a/include/configs/integrator-common.h
+++ b/include/configs/integrator-common.h
@@ -37,7 +37,8 @@
#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
#define CONFIG_SYS_MAXARGS 16 /* max number of command args */
#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size*/
-#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128*1024) /* Size of malloc() pool */
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128*1024)
#define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
#define CONFIG_SETUP_MEMORY_TAGS
diff --git a/include/configs/versatile.h b/include/configs/versatile.h
index a65c676..2484881 100644
--- a/include/configs/versatile.h
+++ b/include/configs/versatile.h
@@ -71,7 +71,7 @@
* Size of malloc() pool
*/
#define CONFIG_ENV_SIZE 8192
-#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
+#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128 * 1024)
/*
* Hardware drivers
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V2] ARM: Fix malloc area size for versatile and integrator
2012-11-03 9:11 ` [U-Boot] [PATCH V2] " Marek Vasut
@ 2013-02-02 23:35 ` Albert ARIBAUD
2013-02-02 23:40 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Albert ARIBAUD @ 2013-02-02 23:35 UTC (permalink / raw)
To: u-boot
Hi Marek,
On Sat, 3 Nov 2012 10:11:27 +0100, Marek Vasut <marex@denx.de> wrote:
> These boards couldn't save their environment because they couldn't malloc()
> the whole size of the sector.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> ---
> include/configs/integrator-common.h | 3 ++-
> include/configs/versatile.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> V2: Align with current code
>
> diff --git a/include/configs/integrator-common.h b/include/configs/integrator-common.h
> index 564b418..51227e7 100644
> --- a/include/configs/integrator-common.h
> +++ b/include/configs/integrator-common.h
> @@ -37,7 +37,8 @@
> #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> #define CONFIG_SYS_MAXARGS 16 /* max number of command args */
> #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size*/
> -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128*1024) /* Size of malloc() pool */
> +/* Size of malloc() pool */
> +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128*1024)
>
> #define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
> #define CONFIG_SETUP_MEMORY_TAGS
> diff --git a/include/configs/versatile.h b/include/configs/versatile.h
> index a65c676..2484881 100644
> --- a/include/configs/versatile.h
> +++ b/include/configs/versatile.h
> @@ -71,7 +71,7 @@
> * Size of malloc() pool
> */
> #define CONFIG_ENV_SIZE 8192
> -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
> +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128 * 1024)
>
> /*
> * Hardware drivers
This does not build properly on current ARM ToT:
board.c:395:19: error: 'CONFIG_ENV_SECT_SIZE' undeclared (first use in
this function)
All 4 of integratorap_cm720t integratorap_cm920t integratorap_cm926ejs
integratorap_cm946es fail.
Amicalement,
--
Albert.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V2] ARM: Fix malloc area size for versatile and integrator
2013-02-02 23:35 ` Albert ARIBAUD
@ 2013-02-02 23:40 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2013-02-02 23:40 UTC (permalink / raw)
To: u-boot
Dear Albert ARIBAUD,
> Hi Marek,
>
> On Sat, 3 Nov 2012 10:11:27 +0100, Marek Vasut <marex@denx.de> wrote:
> > These boards couldn't save their environment because they couldn't
> > malloc() the whole size of the sector.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >
> > include/configs/integrator-common.h | 3 ++-
> > include/configs/versatile.h | 2 +-
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > V2: Align with current code
> >
> > diff --git a/include/configs/integrator-common.h
> > b/include/configs/integrator-common.h index 564b418..51227e7 100644
> > --- a/include/configs/integrator-common.h
> > +++ b/include/configs/integrator-common.h
> > @@ -37,7 +37,8 @@
> >
> > #define
> > CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
> > #define CONFIG_SYS_MAXARGS 16 /* max number of command args */
#define
> > CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument
Buffer Size*/
> >
> > -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128*1024) /*
Size of
> > malloc() pool */ +/* Size of malloc() pool */
> > +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE +
128*1024)
> >
> > #define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */
> > #define CONFIG_SETUP_MEMORY_TAGS
> >
> > diff --git a/include/configs/versatile.h b/include/configs/versatile.h
> > index a65c676..2484881 100644
> > --- a/include/configs/versatile.h
> > +++ b/include/configs/versatile.h
> > @@ -71,7 +71,7 @@
> >
> > * Size of malloc() pool
> > */
> >
> > #define CONFIG_ENV_SIZE 8192
> >
> > -#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 128 * 1024)
> > +#define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SECT_SIZE + 128 *
1024)
> >
> > /*
> >
> > * Hardware drivers
>
> This does not build properly on current ARM ToT:
>
> board.c:395:19: error: 'CONFIG_ENV_SECT_SIZE' undeclared (first use in
> this function)
>
> All 4 of integratorap_cm720t integratorap_cm920t integratorap_cm926ejs
> integratorap_cm946es fail.
Yea well, the original patch is like one year old now ... I guess these things
happen.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-02 23:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-17 2:41 [U-Boot] [PATCH] ARM: Fix malloc area size for versatile and integrator Marek Vasut
2012-03-18 23:34 ` Linus Walleij
2012-03-18 23:37 ` Marek Vasut
2012-11-03 9:11 ` [U-Boot] [PATCH V2] " Marek Vasut
2013-02-02 23:35 ` Albert ARIBAUD
2013-02-02 23:40 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox