From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 19 Mar 2012 04:40:17 +0100 Subject: [U-Boot] [PATCH] mxs_spi: Return proper timeout error In-Reply-To: <1332127415-4903-1-git-send-email-festevam@gmail.com> References: <1332127415-4903-1-git-send-email-festevam@gmail.com> Message-ID: <201203190440.17541.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Fabio Estevam, > Instead of returning -1, it is preferred to return -ETIMEDOUT in case of > timeouts. > > Signed-off-by: Fabio Estevam > --- > drivers/spi/mxs_spi.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c > index adb9ca8..4e6f14e 100644 > --- a/drivers/spi/mxs_spi.c > +++ b/drivers/spi/mxs_spi.c > @@ -162,7 +162,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int > bitlen, if (mx28_wait_mask_set(&ssp_regs->hw_ssp_ctrl0_reg, > SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) { > printf("MXS SPI: Timeout waiting for start\n"); > - return -1; > + return -ETIMEDOUT; > } > > if (tx) > @@ -174,7 +174,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int > bitlen, if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_status_reg, > SSP_STATUS_FIFO_EMPTY, MXS_SPI_MAX_TIMEOUT)) { > printf("MXS SPI: Timeout waiting for data\n"); > - return -1; > + return -ETIMEDOUT; > } > > *rx = readl(&ssp_regs->hw_ssp_data); > @@ -184,7 +184,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int > bitlen, if (mx28_wait_mask_clr(&ssp_regs->hw_ssp_ctrl0_reg, > SSP_CTRL0_RUN, MXS_SPI_MAX_TIMEOUT)) { > printf("MXS SPI: Timeout waiting for finish\n"); > - return -1; > + return -ETIMEDOUT; > } > } Acked-by: Marek Vasut Best regards, Marek Vasut