From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] i.MX28: Drop __naked function from spl_mem_init
Date: Tue, 20 Mar 2012 18:38:48 +0100 [thread overview]
Message-ID: <20120320173848.839DB202A50@gemini.denx.de> (raw)
In-Reply-To: <201203201009.43717.marex@denx.de>
Dear Marek Vasut,
In message <201203201009.43717.marex@denx.de> you wrote:
>
> > > > + const uint32_t data_abort_memdetect_handler = 0xe25ef004;
...
> Because it rewrites piece of RAM, which is then called in the Data abort
> context.
This is a mere implementation detail. You could use a pointer
instead, which would then point to the RO data segment. You could
even use some __attribute__ ((section(".text"))) to make sure the
"instruction" is really in the text segment, for example (untested):
const uint32_t insn __attribute__ ((section(".text"))) = 0xe25ef004;
...
vt[4] = &insn;
?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Without facts, the decision cannot be made logically. You must rely
on your human intuition.
-- Spock, "Assignment: Earth", stardate unknown
next prev parent reply other threads:[~2012-03-20 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Message-Id: <1331903075-10468-1-git-send-email-marex@denx.de>
2012-03-16 21:32 ` [U-Boot] [PATCH V2] i.MX28: Drop __naked function from spl_mem_init Marek Vasut
2012-03-20 7:57 ` Stefano Babic
2012-03-20 8:21 ` Marek Vasut
2012-03-20 8:39 ` Wolfgang Denk
2012-03-20 9:09 ` Marek Vasut
2012-03-20 9:21 ` Stefano Babic
2012-03-20 17:38 ` Wolfgang Denk [this message]
2012-03-20 9:17 ` Stefano Babic
2012-03-20 10:43 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320173848.839DB202A50@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox