From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 26 Mar 2012 14:30:48 +0200
Subject: [U-Boot] [PATCH 08/25] SPEAr: Add configuration options for
	spear3xx and spear6xx boards
In-Reply-To: <4F705C9C.1010606@st.com>
References: <1331121854-20494-1-git-send-email-amit.virdi@st.com>
	<201203071454.08691.sr@denx.de> <4F705C9C.1010606@st.com>
Message-ID: <201203261430.48891.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Amit,

On Monday 26 March 2012 14:10:04 Amit Virdi wrote:
> >> +++ b/board/spear/spear300/config.mk
> >> @@ -25,15 +25,4 @@
> >> 
> >>   CONFIG_SYS_TEXT_BASE = 0x00700000
> >> 
> >> -ALL-y += $(obj)u-boot.img
> >> -
> >> -# Environment variables in NAND
> >> -ifeq ($(ENV),NAND)
> >> -PLATFORM_RELFLAGS += -DCONFIG_ENV_IS_IN_NAND
> >> -else
> >> -PLATFORM_RELFLAGS += -DCONFIG_ENV_IS_IN_FLASH
> >> -endif
> >> -
> >> -ifeq ($(CONSOLE),USB)
> >> -PLATFORM_RELFLAGS += -DCONFIG_SPEAR_USBTTY
> >> -endif
> >> +ALL += $(obj)u-boot.img
> > 
> > Can't you just remove this config.mk file completely?
> > CONFIG_SYS_TEXT_BASE can be moved to the config header instead. What
> > else is this file needed for?
> 
> Could you please explain which config header you are referring to here?
> Do you mean include/configs/spear..... ?

Yes.

> For SPEAr310 and SPEAr320, config.mk is needed to make image (by
> specifying FLASH=PNOR during compile time) that can access CFI compliant
> PNOR flash.

In the example above (spear300), only CONFIG_SYS_TEXT_BASE is left in 
config.mk. This can be moved to the config header (include/configs/spear-xxx-
h).

You should be able to move the other remaining options (PNOR...) to 
boards.cfg. Or is this not possible?

Thanks,
Stefan