From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Patch: Fix device enumeration through API.
Date: Tue, 27 Mar 2012 06:31:49 +0200 [thread overview]
Message-ID: <20120327043149.614AF20024B@gemini.denx.de> (raw)
In-Reply-To: <2A2CB860-6BB6-46C5-B508-F7F97B1EB930@freebsd.org>
Dear Tim Kientzle,
please do not top post / full quote. Especially not when submitting
patches.
In message <2A2CB860-6BB6-46C5-B508-F7F97B1EB930@freebsd.org> you wrote:
> Hello, Anatolij,
>
> Thank you for your response. Modified patch below:
>
>
> On Mar 26, 2012, at 4:06 AM, Anatolij Gustschin wrote:
>
> > Hi Tim,
> >
> > Thanks for the patch. Please see some comments below.
> >
> > On Tue, 21 Feb 2012 22:34:35 -0800
> > Tim Kientzle <kientzle@freebsd.org> wrote:
> >
> >> The one-line patch below fixes device enumeration through the
...
All this would become the commit message - this doesn't work. Any
such comments belong to the comment section, i. e. below the "---" line
which would bepresentif you generated your patches using "git format-
patch".
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If there was anything that depressed him more than his own cynicism,
it was that quite often it still wasn't as cynical as real life.
- Terry Pratchett, _Guards! Guards!_
next prev parent reply other threads:[~2012-03-27 4:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 6:34 [U-Boot] Patch: Fix device enumeration through API Tim Kientzle
2012-03-26 11:06 ` Anatolij Gustschin
2012-03-27 2:46 ` Tim Kientzle
2012-03-27 4:31 ` Wolfgang Denk [this message]
2012-03-27 9:54 ` [U-Boot] [PATCH v2] disk/part.c: " Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327043149.614AF20024B@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox