From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages
Date: Tue, 27 Mar 2012 10:48:26 +0200 [thread overview]
Message-ID: <20120327104826.4e04225e@wker> (raw)
In-Reply-To: <1326497260-13864-1-git-send-email-david.wagner@free-electrons.com>
On Sat, 14 Jan 2012 00:27:34 +0100
David Wagner <david.wagner@free-electrons.com> wrote:
> Also, don't split error messages over several lines as per a coding style
> exception making them easier to grep.
>
> Signed-off-by: David Wagner <david.wagner@free-electrons.com>
> ---
> tools/mkenvimage.c | 41 +++++++++++++++--------------------------
> 1 files changed, 15 insertions(+), 26 deletions(-)
Applied to u-boot-staging/agust at denx.de with minor change.
> @@ -118,7 +113,7 @@ int main(int argc, char **argv)
> usage(prg);
> return EXIT_SUCCESS;
> case 'V':
> - printf("%s version %s\n", prg, PLAIN_VERSION);
> + printf("%s version %s\n", argv[0], PLAIN_VERSION);
> return EXIT_SUCCESS;
> case ':':
> fprintf(stderr, "Missing argument for option -%c\n",
I've dropped this hunk, since recently there was a patch to mkenvimage.c
converting argv[0] to prg.
Thanks,
Anatolij
prev parent reply other threads:[~2012-03-27 8:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 23:27 [U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages David Wagner
2012-01-13 23:27 ` [U-Boot] [PATCHv5 2/7] mkenvimage: Correct an include and add a missing one David Wagner
2012-01-15 1:23 ` Mike Frysinger
2012-03-27 8:50 ` Anatolij Gustschin
2012-01-13 23:27 ` [U-Boot] [PATCHv5 3/7] mkenvimage: More error handling David Wagner
2012-01-15 1:24 ` Mike Frysinger
2012-03-27 8:51 ` Anatolij Gustschin
2012-01-13 23:27 ` [U-Boot] [PATCHv5 4/7] mkenvimage: Read/Write from/to stdin/out by default or if the filename is "-" David Wagner
2012-01-15 1:25 ` Mike Frysinger
2012-03-27 8:52 ` Anatolij Gustschin
2012-01-13 23:27 ` [U-Boot] [PATCHv5 5/7] mkenvimage: Use mmap() when reading from a regular file David Wagner
2012-01-15 1:25 ` Mike Frysinger
2012-03-27 8:52 ` Anatolij Gustschin
2012-01-13 23:27 ` [U-Boot] [PATCHv5 6/7] mkenvimage: Don't try to detect comments in the input file David Wagner
2012-01-15 1:26 ` Mike Frysinger
2012-03-27 8:53 ` Anatolij Gustschin
2012-01-13 23:27 ` [U-Boot] [PATCHv5 7/7] mkenvimage: Really set the redundant byte when applicable David Wagner
2012-01-15 1:26 ` Mike Frysinger
2012-03-27 8:53 ` Anatolij Gustschin
2012-01-15 1:22 ` [U-Boot] [PATCHv5 1/7] mkenvimage: correct and clarify comments and error messages Mike Frysinger
2012-02-26 0:19 ` David Wagner
2012-03-27 8:32 ` Anatolij Gustschin
2012-03-27 20:37 ` David Wagner
2012-03-27 8:48 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327104826.4e04225e@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox