public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] configs: EB+MCF-EV123.h: Fix typo on CONFIG_SYS_HUSH_PARSER
Date: Tue, 27 Mar 2012 11:23:16 +0200	[thread overview]
Message-ID: <20120327112316.09e53f84@wker> (raw)
In-Reply-To: <1332800612-2304-1-git-send-email-festevam@gmail.com>

Hello Fabio,

On Mon, 26 Mar 2012 19:23:32 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Fix typo on CONFIG_SYS_HUSH_PARSER.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/EB+MCF-EV123.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/EB+MCF-EV123.h b/include/configs/EB+MCF-EV123.h
> index 1f774a9..7f2bd01 100644
> --- a/include/configs/EB+MCF-EV123.h
> +++ b/include/configs/EB+MCF-EV123.h
> @@ -90,7 +90,7 @@
>  
>  
>  #define CONFIG_BOOTDELAY	5
> -#define CONFIG_HUSH_PARSER
> +#define CONFIG_SYS_HUSH_PARSER
>  #define CONFIG_SYS_PROMPT	"\nEV123 U-Boot> "
>  #define	CONFIG_SYS_LONGHELP	1

This patch will break compiling since CONFIG_SYS_PROMPT_HUSH_PS2 is
not defined.

We should probably define default CONFIG_SYS_PROMPT_HUSH_PS2 in
common/hush.c and let the board config files to override it if
they want a different secondary prompt.

Thanks,
Anatolij

      reply	other threads:[~2012-03-27  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 22:23 [U-Boot] [PATCH] configs: EB+MCF-EV123.h: Fix typo on CONFIG_SYS_HUSH_PARSER Fabio Estevam
2012-03-27  9:23 ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120327112316.09e53f84@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox