* [U-Boot] [PATCH] board/vpac270/onenand.c: Fix build errors
@ 2012-03-28 15:38 Anatolij Gustschin
2012-03-28 15:56 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Anatolij Gustschin @ 2012-03-28 15:38 UTC (permalink / raw)
To: u-boot
Building for vpac270_ond_256 configuration fails:
arch/arm/lib/libarm.o: In function `icache_disable':
/home/ag/git/u-boot/arch/arm/lib/cache-cp15.c:156: multiple
definition of `icache_disable'
board/vpac270/libvpac270.o:/home/ag/git/u-boot/board/vpac270/onenand.c:65:
first defined here
arch/arm/lib/libarm.o: In function `dcache_disable':
/home/ag/git/u-boot/arch/arm/lib/cache-cp15.c:188: multiple
definition of `dcache_disable'
board/vpac270/libvpac270.o:/home/ag/git/u-boot/board/vpac270/onenand.c:66:
first defined here
make[1]: *** [/home/ag/git/u-boot/spl/u-boot-spl] Error 1
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
---
Hi Marek,
After pulling Albert's u-boot-arm.git master and running
build tests I see this error. Is this fix correct?
Anatolij
board/vpac270/onenand.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/board/vpac270/onenand.c b/board/vpac270/onenand.c
index c2ae9a7..47f44c3 100644
--- a/board/vpac270/onenand.c
+++ b/board/vpac270/onenand.c
@@ -60,6 +60,3 @@ void __attribute__((noreturn)) hang(void)
for (;;)
;
}
-
-void icache_disable(void) {}
-void dcache_disable(void) {}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* [U-Boot] [PATCH] board/vpac270/onenand.c: Fix build errors
2012-03-28 15:38 [U-Boot] [PATCH] board/vpac270/onenand.c: Fix build errors Anatolij Gustschin
@ 2012-03-28 15:56 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2012-03-28 15:56 UTC (permalink / raw)
To: u-boot
Dear Anatolij Gustschin,
> Building for vpac270_ond_256 configuration fails:
>
> arch/arm/lib/libarm.o: In function `icache_disable':
> /home/ag/git/u-boot/arch/arm/lib/cache-cp15.c:156: multiple
> definition of `icache_disable'
> board/vpac270/libvpac270.o:/home/ag/git/u-boot/board/vpac270/onenand.c:65:
> first defined here
> arch/arm/lib/libarm.o: In function `dcache_disable':
> /home/ag/git/u-boot/arch/arm/lib/cache-cp15.c:188: multiple
> definition of `dcache_disable'
> board/vpac270/libvpac270.o:/home/ag/git/u-boot/board/vpac270/onenand.c:66:
> first defined here
> make[1]: *** [/home/ag/git/u-boot/spl/u-boot-spl] Error 1
Awwww ... bad, bad maintainer I am. :-(
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
> Hi Marek,
>
> After pulling Albert's u-boot-arm.git master and running
> build tests I see this error. Is this fix correct?
>
> Anatolij
>
> board/vpac270/onenand.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/board/vpac270/onenand.c b/board/vpac270/onenand.c
> index c2ae9a7..47f44c3 100644
> --- a/board/vpac270/onenand.c
> +++ b/board/vpac270/onenand.c
> @@ -60,6 +60,3 @@ void __attribute__((noreturn)) hang(void)
> for (;;)
> ;
> }
> -
> -void icache_disable(void) {}
> -void dcache_disable(void) {}
Looks ok:
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-28 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-28 15:38 [U-Boot] [PATCH] board/vpac270/onenand.c: Fix build errors Anatolij Gustschin
2012-03-28 15:56 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox