public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] drivers/mmc/mmc.c: Fix build warning
@ 2012-03-29  7:24 Anatolij Gustschin
  2012-03-29 10:28 ` Marek Vasut
  2012-03-30 20:19 ` Wolfgang Denk
  0 siblings, 2 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2012-03-29  7:24 UTC (permalink / raw)
  To: u-boot

Fix:
mmc.c: In function 'mmc_bounce_buffer_start':
mmc.c:132:13: warning: no return statement in function returning
non-void [-Wreturn-type]

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Andy Fleming <afleming@gmail.com>
Cc: Marek Vasut <marex@denx.de>
---
Note: This appears when building with merged u-boot-arm.git master.

 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 74e5fea..e70fa9f 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -129,7 +129,7 @@ static void mmc_bounce_buffer_stop(struct mmc_data *backup,
 }
 #else
 static inline int mmc_bounce_buffer_start(struct mmc_data *backup,
-					struct mmc_data *orig) { }
+					struct mmc_data *orig) { return 0; }
 static inline void mmc_bounce_buffer_stop(struct mmc_data *backup,
 					struct mmc_data *orig) { }
 #endif
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] drivers/mmc/mmc.c: Fix build warning
  2012-03-29  7:24 [U-Boot] [PATCH] drivers/mmc/mmc.c: Fix build warning Anatolij Gustschin
@ 2012-03-29 10:28 ` Marek Vasut
  2012-03-30 20:19 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2012-03-29 10:28 UTC (permalink / raw)
  To: u-boot

Dear Anatolij Gustschin,

> Fix:
> mmc.c: In function 'mmc_bounce_buffer_start':
> mmc.c:132:13: warning: no return statement in function returning
> non-void [-Wreturn-type]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Andy Fleming <afleming@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> Note: This appears when building with merged u-boot-arm.git master.
> 
>  drivers/mmc/mmc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 74e5fea..e70fa9f 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -129,7 +129,7 @@ static void mmc_bounce_buffer_stop(struct mmc_data
> *backup, }
>  #else
>  static inline int mmc_bounce_buffer_start(struct mmc_data *backup,
> -					struct mmc_data *orig) { }
> +					struct mmc_data *orig) { return 0; }
>  static inline void mmc_bounce_buffer_stop(struct mmc_data *backup,
>  					struct mmc_data *orig) { }
>  #endif

Dang :/

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] drivers/mmc/mmc.c: Fix build warning
  2012-03-29  7:24 [U-Boot] [PATCH] drivers/mmc/mmc.c: Fix build warning Anatolij Gustschin
  2012-03-29 10:28 ` Marek Vasut
@ 2012-03-30 20:19 ` Wolfgang Denk
  1 sibling, 0 replies; 3+ messages in thread
From: Wolfgang Denk @ 2012-03-30 20:19 UTC (permalink / raw)
  To: u-boot

Dear Anatolij Gustschin,

In message <1333005872-4325-1-git-send-email-agust@denx.de> you wrote:
> Fix:
> mmc.c: In function 'mmc_bounce_buffer_start':
> mmc.c:132:13: warning: no return statement in function returning
> non-void [-Wreturn-type]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Andy Fleming <afleming@gmail.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> Note: This appears when building with merged u-boot-arm.git master.

Applied, thanks.

Albert, Andy: hope this is OK with you.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Morality is one thing.  Ratings are everything."
- A Network 23 executive on "Max Headroom"

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-30 20:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-29  7:24 [U-Boot] [PATCH] drivers/mmc/mmc.c: Fix build warning Anatolij Gustschin
2012-03-29 10:28 ` Marek Vasut
2012-03-30 20:19 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox