public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] lsxl: add support for lschlv2 and lsxhl
Date: Fri, 30 Mar 2012 15:57:14 +0200	[thread overview]
Message-ID: <201203301557.14776.michael@walle.cc> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A2F771230@SC-VEXCH4.marvell.com>


Hi Prafulla,

[ I'm CCing Wolfgang on this, because i don't know who's responsible for the 
build/make infrastructure. ]

> AFAIK, you need to pass only "u-boot.kwb" to the make (no $(okj) needed)
Sorry you're wrong here, that won't work for out-of-tree builds, see below.

[mw at thanatos b-u-boot]$ LANG=C make -j3 -C ../u-boot O=`pwd` 
CROSS_COMPILE=arm-linux-gnueabi- u-boot.kwb
make: Entering directory `/home/mw/repo/u-boot'
make: *** No rule to make target `u-boot.kwb'.  Stop.
make: Leaving directory `/home/mw/repo/u-boot'

> >  - i'm only interested in the u-boot.kwb, why shouldn't it be
> > 
> > generated by
> > default?
> > 
> >  - i can't build it with a sinlge make call. Eg. atm i'm doing
> >  
> >     make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi-
> > 
> > lschlv2
> > 
> >    otherwise i have to do
> >    
> >     make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi-
> > 
> > lschlv2
> > 
> >     make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi- \
> >     
> >        `pwd`/u-boot.kwb
> 
> "make u-boot.kwb CROSS_COMPILE=arm-linux-gnueabi-"
> generates u-boot.kwb, this should be valid with other use case too.
> if not, it makes sense to add an additional line in script that a file in
> code :-)

Mh, i don't understands what is wrong with a config.mk with only an additional 
make target? There are other boards too, which handles image generating this 
way (grep for ALL-y in boards/). Shouldn't be building an uboot image as 
simple as possible?

If we add
  .PHONY: u-boot.kwb
  u-boot.kwb: $(obj)u-boot.kwb
to the main Makefile, i would say we should add all other image targets, too.

I'd say one could add the target to the kirkwood config.mk (if there is one 
per platform) but i doubt every kirkwood based board will need one (and 
provides a kwbimage.cfg).

-- 
Michael

  reply	other threads:[~2012-03-30 13:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 15:02 [U-Boot] [PATCH v2] lsxl: add support for lschlv2 and lsxhl Michael Walle
2012-03-26 10:15 ` Michael Walle
2012-03-27  7:27   ` Prafulla Wadaskar
2012-03-27 20:38     ` Michael Walle
2012-03-29 12:38     ` Michael Walle
2012-03-29 14:24       ` Prafulla Wadaskar
2012-03-29 14:39         ` Michael Walle
2012-03-30 11:18           ` Prafulla Wadaskar
2012-03-30 13:57             ` Michael Walle [this message]
2012-04-02  6:37               ` Prafulla Wadaskar
2012-03-27  7:28   ` Prafulla Wadaskar
  -- strict thread matches above, loose matches on Subject: below --
2012-03-27 10:51 Michael Walle
2012-03-27 11:05 ` Prafulla Wadaskar
2012-03-27 20:55   ` Michael Walle
2012-03-27 21:13     ` Wolfgang Denk
2012-03-29 11:30       ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203301557.14776.michael@walle.cc \
    --to=michael@walle.cc \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox