From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Walle <michael@walle.cc>
Date: Fri, 30 Mar 2012 15:57:14 +0200
Subject: [U-Boot] [PATCH v2] lsxl: add support for lschlv2 and lsxhl
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A2F771230@SC-VEXCH4.marvell.com>
References: <1330700546-27631-1-git-send-email-michael@walle.cc>
	<201203291639.18602.michael@walle.cc>
	<F766E4F80769BD478052FB6533FA745D1A2F771230@SC-VEXCH4.marvell.com>
Message-ID: <201203301557.14776.michael@walle.cc>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


Hi Prafulla,

[ I'm CCing Wolfgang on this, because i don't know who's responsible for the 
build/make infrastructure. ]

> AFAIK, you need to pass only "u-boot.kwb" to the make (no $(okj) needed)
Sorry you're wrong here, that won't work for out-of-tree builds, see below.

[mw at thanatos b-u-boot]$ LANG=C make -j3 -C ../u-boot O=`pwd` 
CROSS_COMPILE=arm-linux-gnueabi- u-boot.kwb
make: Entering directory `/home/mw/repo/u-boot'
make: *** No rule to make target `u-boot.kwb'.  Stop.
make: Leaving directory `/home/mw/repo/u-boot'

> >  - i'm only interested in the u-boot.kwb, why shouldn't it be
> > 
> > generated by
> > default?
> > 
> >  - i can't build it with a sinlge make call. Eg. atm i'm doing
> >  
> >     make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi-
> > 
> > lschlv2
> > 
> >    otherwise i have to do
> >    
> >     make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi-
> > 
> > lschlv2
> > 
> >     make -j3 -C ../u-boot O=`pwd` CROSS_COMPILE=arm-linux-gnueabi- \
> >     
> >        `pwd`/u-boot.kwb
> 
> "make u-boot.kwb CROSS_COMPILE=arm-linux-gnueabi-"
> generates u-boot.kwb, this should be valid with other use case too.
> if not, it makes sense to add an additional line in script that a file in
> code :-)

Mh, i don't understands what is wrong with a config.mk with only an additional 
make target? There are other boards too, which handles image generating this 
way (grep for ALL-y in boards/). Shouldn't be building an uboot image as 
simple as possible?

If we add
  .PHONY: u-boot.kwb
  u-boot.kwb: $(obj)u-boot.kwb
to the main Makefile, i would say we should add all other image targets, too.

I'd say one could add the target to the kirkwood config.mk (if there is one 
per platform) but i doubt every kirkwood based board will need one (and 
provides a kwbimage.cfg).

-- 
Michael