From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules
Date: Sat, 31 Mar 2012 20:31:25 +0200 [thread overview]
Message-ID: <201203312031.25497.marex@denx.de> (raw)
In-Reply-To: <7605B15734F74B40A124AED46B25250A4F257F@HEFRMBX01.sofr.hefr.lan>
Dear Gachet Daniel,
> This short patch correct corrupted data while reading NAND flash modules on
> the KARO TX25 module.
>
> The current version of the mxc_nand driver uses the symmetric mode to
> access the NAND flash, but the devices populated on the KARO TX25 only
> support an asymmetric mode (i.MX25: bit 8 within NAND_FLASH_CONFIG1
> register cleared).
>
> Signed-off-by: Daniel Gachet <daniel.gachet@hefr.ch>
> Cc: Wolfgang Denk <wd@denx.de >
>
> diff -upr drivers/mtd/nand/mxc_nand.c drivers/mtd/nand/mxc_nand.c
> --- drivers/mtd/nand/mxc_nand.c 2011-12-23 20:25:35.000000000 +0100
> +++ drivers/mtd/nand/mxc_nand.c 2012-03-30 08:10:13.000000000 +0200
> @@ -1290,7 +1290,9 @@ static void mxc_setup_config1(void)
> uint16_t tmp;
>
> tmp = readw(&host->regs->nfc_config1);
> +#ifndef MACH_TYPE_TX25
> tmp |= NFC_ONE_CYCLE;
> +#endif
> tmp |= NFC_4_8N_ECC;
> writew(tmp, &host->regs->nfc_config1);
> if (host->pagesize_2k)
>
Won't it be better to make this more generic rather then adding more machine-
specific hacks please?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-03-31 18:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-31 7:31 [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules Gachet Daniel
2012-03-31 18:31 ` Marek Vasut [this message]
2012-04-01 8:56 ` Gachet Daniel
2012-04-01 13:43 ` Marek Vasut
2012-04-01 10:33 ` stefano babic
2012-04-01 19:09 ` Gachet Daniel
2012-04-01 21:02 ` Marek Vasut
[not found] ` <7605B15734F74B40A124AED46B25250A4F26AD@HEFRMBX01.sofr.hefr.lan>
2012-04-02 13:39 ` Marek Vasut
[not found] ` <7605B15734F74B40A124AED46B25250A4F2809@HEFRMBX01.sofr.hefr.lan>
2012-04-02 18:18 ` stefano babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203312031.25497.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox