* [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
@ 2012-03-08 12:35 Dirk Behme
2012-03-31 8:12 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dirk Behme @ 2012-03-08 12:35 UTC (permalink / raw)
To: u-boot
Fix the warning
mmc.c: In function 'mmc_send_cmd':
mmc.c:87: warning: assignment from incompatible pointer type
in case CONFIG_MMC_TRACE is enabled.
Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
CC: Andy Fleming <afleming@freescale.com>
---
drivers/mmc/mmc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 21665ec..881b5c0 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
for (i = 0; i < 4; i++) {
int j;
printf("\t\t\t\t\t%03d - ", i*4);
- ptr = &cmd->response[i];
+ ptr = (u8 *)&cmd->response[i];
ptr += 3;
for (j = 0; j < 4; j++)
printf("%02X ", *ptr--);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
2012-03-08 12:35 [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled Dirk Behme
@ 2012-03-31 8:12 ` Simon Glass
2012-03-31 18:35 ` Marek Vasut
2012-04-21 15:03 ` Wolfgang Denk
2 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2012-03-31 8:12 UTC (permalink / raw)
To: u-boot
On Thu, Mar 8, 2012 at 4:35 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:
> Fix the warning
>
> mmc.c: In function 'mmc_send_cmd':
> mmc.c:87: warning: assignment from incompatible pointer type
>
> in case CONFIG_MMC_TRACE is enabled.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Andy Fleming <afleming@freescale.com>
Acked-by: Simon Glass <sjg@chromium.org>
> ---
> ?drivers/mmc/mmc.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 21665ec..881b5c0 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)
> ? ? ? ? ? ? ? ? ? ? ? ?for (i = 0; i < 4; i++) {
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?int j;
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?printf("\t\t\t\t\t%03d - ", i*4);
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ptr = &cmd->response[i];
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ptr = (u8 *)&cmd->response[i];
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?ptr += 3;
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?for (j = 0; j < 4; j++)
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?printf("%02X ", *ptr--);
> --
> 1.7.0.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
2012-03-08 12:35 [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled Dirk Behme
2012-03-31 8:12 ` Simon Glass
@ 2012-03-31 18:35 ` Marek Vasut
2012-04-18 10:52 ` Dirk Behme
2012-04-21 15:03 ` Wolfgang Denk
2 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2012-03-31 18:35 UTC (permalink / raw)
To: u-boot
Dear Dirk Behme,
> Fix the warning
>
> mmc.c: In function 'mmc_send_cmd':
> mmc.c:87: warning: assignment from incompatible pointer type
>
> in case CONFIG_MMC_TRACE is enabled.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Andy Fleming <afleming@freescale.com>
> ---
Acked-by: Marek Vasut <marex@denx.de>
> drivers/mmc/mmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index 21665ec..881b5c0 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> struct mmc_data *data) for (i = 0; i < 4; i++) {
> int j;
> printf("\t\t\t\t\t%03d - ", i*4);
> - ptr = &cmd->response[i];
> + ptr = (u8 *)&cmd->response[i];
> ptr += 3;
> for (j = 0; j < 4; j++)
> printf("%02X ", *ptr--);
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
2012-03-31 18:35 ` Marek Vasut
@ 2012-04-18 10:52 ` Dirk Behme
2012-04-18 12:23 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Dirk Behme @ 2012-04-18 10:52 UTC (permalink / raw)
To: u-boot
On 31.03.2012 20:35, Marek Vasut wrote:
> Dear Dirk Behme,
>
>> Fix the warning
>>
>> mmc.c: In function 'mmc_send_cmd':
>> mmc.c:87: warning: assignment from incompatible pointer type
>>
>> in case CONFIG_MMC_TRACE is enabled.
>>
>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
>> CC: Andy Fleming <afleming@freescale.com>
>> ---
>
> Acked-by: Marek Vasut <marex@denx.de>
> Acked-by: Simon Glass <sjg@chromium.org>
>
>> drivers/mmc/mmc.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index 21665ec..881b5c0 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>> struct mmc_data *data) for (i = 0; i < 4; i++) {
>> int j;
>> printf("\t\t\t\t\t%03d - ", i*4);
>> - ptr = &cmd->response[i];
>> + ptr = (u8 *)&cmd->response[i];
>> ptr += 3;
>> for (j = 0; j < 4; j++)
>> printf("%02X ", *ptr--);
Who could help to still get this into 2012.04?
Many thanks,
Dirk
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
2012-04-18 10:52 ` Dirk Behme
@ 2012-04-18 12:23 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2012-04-18 12:23 UTC (permalink / raw)
To: u-boot
Dear Dirk Behme,
> On 31.03.2012 20:35, Marek Vasut wrote:
> > Dear Dirk Behme,
> >
> >> Fix the warning
> >>
> >> mmc.c: In function 'mmc_send_cmd':
> >> mmc.c:87: warning: assignment from incompatible pointer type
> >>
> >> in case CONFIG_MMC_TRACE is enabled.
> >>
> >> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> >> CC: Andy Fleming <afleming@freescale.com>
I'd be glad to see it in ... Andy?
> >> ---
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > Acked-by: Simon Glass <sjg@chromium.org>
> >
> >> drivers/mmc/mmc.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> >> index 21665ec..881b5c0 100644
> >> --- a/drivers/mmc/mmc.c
> >> +++ b/drivers/mmc/mmc.c
> >> @@ -84,7 +84,7 @@ int mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> >> struct mmc_data *data) for (i = 0; i < 4; i++) {
> >>
> >> int j;
> >> printf("\t\t\t\t\t%03d - ", i*4);
> >>
> >> - ptr = &cmd->response[i];
> >> + ptr = (u8 *)&cmd->response[i];
> >>
> >> ptr += 3;
> >> for (j = 0; j < 4; j++)
> >>
> >> printf("%02X ", *ptr--);
>
> Who could help to still get this into 2012.04?
>
> Many thanks,
>
> Dirk
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled
2012-03-08 12:35 [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled Dirk Behme
2012-03-31 8:12 ` Simon Glass
2012-03-31 18:35 ` Marek Vasut
@ 2012-04-21 15:03 ` Wolfgang Denk
2 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2012-04-21 15:03 UTC (permalink / raw)
To: u-boot
Dear Dirk Behme,
In message <1331210134-11682-1-git-send-email-dirk.behme@de.bosch.com> you wrote:
> Fix the warning
>
> mmc.c: In function 'mmc_send_cmd':
> mmc.c:87: warning: assignment from incompatible pointer type
>
> in case CONFIG_MMC_TRACE is enabled.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Andy Fleming <afleming@freescale.com>
> ---
> drivers/mmc/mmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Science makes godlike -- it is all over with priests and gods when
man becomes scientific. Moral: science is the forbidden as such -- it
alone is forbidden. Science is the *first* sin, the *original* sin.
*This alone is morality.* ``Thou shalt not know'' -- the rest
follows." - Friedrich Nietzsche
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-21 15:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08 12:35 [U-Boot] [PATCH] mmc: Fix warning if CONFIG_MMC_TRACE is enabled Dirk Behme
2012-03-31 8:12 ` Simon Glass
2012-03-31 18:35 ` Marek Vasut
2012-04-18 10:52 ` Dirk Behme
2012-04-18 12:23 ` Marek Vasut
2012-04-21 15:03 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox