public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/14] CMD: Remove CMD_MEM and CMD_LOOPW, they're unused
Date: Sat, 31 Mar 2012 23:29:18 +0200	[thread overview]
Message-ID: <201203312329.18669.marex@denx.de> (raw)
In-Reply-To: <20120331225908.3af5779b@wker>

Dear Anatolij Gustschin,

> Hi Marek,
> 
> On Sat, 31 Mar 2012 19:47:15 +0200
> 
> Marek Vasut <marex@denx.de> wrote:
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > ---
> > 
> >  README |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/README b/README
> > index c98afa7..0ebe877 100644
> > --- a/README
> > +++ b/README
> > 
> > @@ -3379,10 +3379,6 @@ Low Level (hardware related) configuration options:
> >  		and crc32 is the correct crc32 which the
> >  		area should have.
> > 
> > -- CONFIG_LOOPW
> > -		Add the "loopw" memory command. This only takes effect if
> > -		the memory commands are activated globally (CONFIG_CMD_MEM).
> 
> Please, no. CONFIG_LOOPW is used if CONFIG_CMD_MEMORY is defined. This
> text should be fixed instead: s/CONFIG_CMD_MEM/CONFIG_CMD_MEMORY/

DAMN, it's not CONFIG_CMD ... scrap this patch, good catch!
> 
> Also it probably makes sense to change CONFIG_LOOPW to CONFIG_CMD_LOOPW
> since this configures an U-Boot command.

Agreed!
> 
> Same for CONFIG_MX_CYCLIC.

Yes.
> 
> ...
> 
> > @@ -3394,9 +3390,6 @@ Low Level (hardware related) configuration options:
> >  		=> mwc.l 100 12345678 10
> >  		This command will write 12345678 to address 100 all 10 ms.
> > 
> > -		This only takes effect if the memory commands are activated
> > -		globally (CONFIG_CMD_MEM).
> > -
> 
> Same applies here.
> 
> Thanks,
> Anatolij

Best regards,
Marek Vasut

  reply	other threads:[~2012-03-31 21:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-31 17:47 [U-Boot] [PATCH 01/14] AT91: Drop AT91_SPIMUX command from cmd_all Marek Vasut
2012-03-31 17:47 ` [U-Boot] [PATCH 02/14] CMD: Remove CMD_AUTOSCRIPT, it's not used Marek Vasut
2012-03-31 20:06   ` Anatolij Gustschin
2012-03-31 17:47 ` [U-Boot] [PATCH 03/14] CMD: Drop CMD_CAN, " Marek Vasut
2012-03-31 17:47 ` [U-Boot] [PATCH 04/14] CMD: Drop CMD_DCR, " Marek Vasut
2012-03-31 20:08   ` Anatolij Gustschin
2012-03-31 20:13     ` Marek Vasut
2012-03-31 17:47 ` [U-Boot] [PATCH 05/14] CMD: Drop CONFIG_CMD_DFL, " Marek Vasut
2012-03-31 20:13   ` Anatolij Gustschin
2012-04-02  0:12   ` Nobuhiro Iwamatsu
2012-03-31 17:47 ` [U-Boot] [PATCH 06/14] CMD: Drop CONFIG_CMD_EMMC, " Marek Vasut
2012-03-31 17:47 ` [U-Boot] [PATCH 07/14] CMD: Fix typo KGBD -> KGDB on debris board Marek Vasut
2012-03-31 21:02   ` Anatolij Gustschin
2012-03-31 21:28     ` Marek Vasut
2012-03-31 17:47 ` [U-Boot] [PATCH 08/14] CMD: Remove CMD_LOG, it's unused Marek Vasut
2012-03-31 21:09   ` Anatolij Gustschin
2012-03-31 17:47 ` [U-Boot] [PATCH 09/14] HWW1U1A: Fix CMD_SHA1 -> CMD_SHA1SUM Marek Vasut
2012-03-31 21:03   ` Anatolij Gustschin
2012-03-31 17:47 ` [U-Boot] [PATCH 10/14] CMD: Remove CMD_MEM and CMD_LOOPW, they're unused Marek Vasut
2012-03-31 20:59   ` Anatolij Gustschin
2012-03-31 21:29     ` Marek Vasut [this message]
2012-03-31 17:47 ` [U-Boot] [PATCH 11/14] CMD: Fix typo CMD_FSL -> CMD_MFSL in readme Marek Vasut
2012-03-31 21:11   ` Anatolij Gustschin
2012-03-31 17:47 ` [U-Boot] [PATCH 12/14] CMD: Fix CONFIG_CMD_SAVEBP_WRITE_SIZE -> CONFIG_CMD_SPL_WRITE_SIZE Marek Vasut
2012-03-31 17:47 ` [U-Boot] [PATCH 13/14] CMD: CONFIG_CMD_SETECPR -> CONFIG_CMD_SETEXPR on omap3_logic Marek Vasut
2012-03-31 21:20   ` Anatolij Gustschin
2012-03-31 17:47 ` [U-Boot] [PATCH 14/14] CMD: Fix CONFIG_CMD_STORAGE -> CONFIG_CMD_USB_STORAGE Marek Vasut
2012-03-31 22:35   ` Anatolij Gustschin
2012-03-31 20:04 ` [U-Boot] [PATCH 01/14] AT91: Drop AT91_SPIMUX command from cmd_all Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201203312329.18669.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox