From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 1 Apr 2012 15:48:46 -0400 Subject: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands In-Reply-To: <1333179058-19598-1-git-send-email-sjg@chromium.org> References: <1333179058-19598-1-git-send-email-sjg@chromium.org> Message-ID: <201204011548.48522.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 31 March 2012 03:30:55 Simon Glass wrote: > --- a/common/cmd_pxe.c > +++ b/common/cmd_pxe.c > > + return run_command_list(localcmd, strlen(localcmd), 0); should be -1 instead of strlen() > +int run_command_list(const char *cmd, int len, int flag) > +{ > + int need_buff = 1; > + char *buff = (char *)cmd; /* cast away const */ > + int rcode = 0; > + > + if (len == -1) { > + len = strlen(cmd); > +#ifdef CONFIG_SYS_HUSH_PARSER > + /* hush will never change our string */ > + need_buff = 0; > +#else > + /* the built-in parser will change our string if it sees \n */ > + need_buff = strchr(cmd, '\n') != NULL; > +#endif > + } we have memchr(), so you should be able to split the len==-1 and the need_buff logic into two sep steps also, should you handle the case where '\n' is the very last char ? or not bother ? -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: