From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V6] BOOT: Add "bootz" command to boot Linux zImage on ARM
Date: Sun, 1 Apr 2012 16:02:43 +0200 [thread overview]
Message-ID: <201204011602.44001.marex@denx.de> (raw)
In-Reply-To: <4F783B0F.9010504@gmail.com>
Dear Graeme Russ,
> Hi Marek,
>
> On 04/01/2012 05:27 AM, Marek Vasut wrote:
> > Dear Mike Frysinger,
> >
> >> On Thursday 15 March 2012 03:52:45 Marek Vasut wrote:
> >>> --- a/common/cmd_bootm.c
> >>> +++ b/common/cmd_bootm.c
> >>>
> >>> -static void bootm_start_lmb(void)
> >>> -{
> >>>
> >>> #ifdef CONFIG_LMB
> >>>
> >>> +static void boot_start_lmb(bootm_headers_t *images)
> >>> +{
> >>>
> >>> ulong mem_start;
> >>> phys_size_t mem_size;
> >>>
> >>> - lmb_init(&images.lmb);
> >>> + lmb_init(&images->lmb);
> >>>
> >>> mem_start = getenv_bootm_low();
> >>> mem_size = getenv_bootm_size();
> >>>
> >>> - lmb_add(&images.lmb, (phys_addr_t)mem_start, mem_size);
> >>> + lmb_add(&images->lmb, (phys_addr_t)mem_start, mem_size);
> >>>
> >>> - arch_lmb_reserve(&images.lmb);
> >>> - board_lmb_reserve(&images.lmb);
> >>> + arch_lmb_reserve(&images->lmb);
> >>> + board_lmb_reserve(&images->lmb);
> >>> +}
> >>>
> >>> #else
> >>>
> >>> -# define lmb_reserve(lmb, base, size)
> >>> +static inline void boot_start_lmb(bootm_headers_t *images) { }
> >>>
> >>> #endif
> >>>
> >>> -}
> >>
> >> this breaks all non-lmb configs. before, lmb_reverse() was stubbed out,
> >> but now it's not, leading to build failures:
> >>
> >> cmd_bootm.c: In function ?do_bootm_subcommand?:
> >> cmd_bootm.c:518:23: error: ?bootm_headers_t? has no member named ?lmb?
> >> cmd_bootm.c: In function ?do_bootm?:
> >> cmd_bootm.c:665:21: error: ?bootm_headers_t? has no member named ?lmb?
> >> make[2]: *** [cmd_bootm.o] Error 1
> >> -mike
> >
> > Well tested on arm/ppc ... can you submit patch for these platforms
> > please ?
>
> I think the 'You Break, You Fix' rule applies ;)
>
> > I'll be able to run mips/x86 next week.
>
> Dang, I need it building now :P
>
> I'm going to but in some really dodgy hacks just to get my build going
> again, but I would appreciate a fix ASAP
>
> Regards,
>
> Graeme
Sent.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-01 14:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Message-Id: <1331696876-20903-1-git-send-email-marex@denx.de>
2012-03-15 7:52 ` [U-Boot] [PATCH V6] BOOT: Add "bootz" command to boot Linux zImage on ARM Marek Vasut
2012-03-15 18:51 ` Rob Herring
2012-03-15 19:05 ` Marek Vasut
2012-03-15 19:48 ` Rob Herring
2012-03-15 20:29 ` Marek Vasut
2012-03-15 21:10 ` Rob Herring
2012-03-15 22:02 ` Rob Herring
2012-03-16 0:53 ` Marek Vasut
2012-03-16 7:16 ` Wolfgang Denk
2012-03-16 18:20 ` Rob Herring
2012-03-15 20:39 ` Wolfgang Denk
2012-03-30 20:59 ` Wolfgang Denk
2012-03-31 19:10 ` Mike Frysinger
2012-03-31 19:27 ` Marek Vasut
2012-04-01 11:25 ` Graeme Russ
2012-04-01 14:02 ` Marek Vasut [this message]
[not found] <Message-Id: <1331689093-19211-1-git-send-email-marex@denx.de>
2012-03-14 3:47 ` [U-Boot] [PATCH V5] " Marek Vasut
2012-03-14 5:07 ` Mike Frysinger
2012-03-14 5:38 ` Marek Vasut
2012-03-14 18:35 ` Mike Frysinger
2012-03-14 19:27 ` Marek Vasut
2012-03-15 16:09 ` Wolfgang Denk
2012-03-15 17:08 ` Marek Vasut
2012-03-15 17:36 ` Mike Frysinger
2012-03-15 17:40 ` Marek Vasut
2012-03-14 16:45 ` Stephen Warren
2012-03-14 17:23 ` Marek Vasut
[not found] <Message-Id: <1331588061-21546-1-git-send-email-marex@denx.de>
2012-03-12 21:34 ` [U-Boot] [PATCH V3] BOOT: Add "bootz" command to boot Linux zImage Marek Vasut
2012-03-12 22:03 ` Wolfgang Denk
2012-03-12 22:08 ` Marek Vasut
2012-03-12 22:42 ` Wolfgang Denk
2012-03-13 0:13 ` Marek Vasut
2012-03-13 0:22 ` Graeme Russ
2012-03-13 4:30 ` Wolfgang Denk
2012-03-13 4:46 ` Graeme Russ
2012-03-15 15:03 ` Wolfgang Denk
2012-03-15 17:08 ` Marek Vasut
2012-03-13 4:47 ` Marek Vasut
2012-03-15 15:06 ` Wolfgang Denk
2012-03-15 17:18 ` Marek Vasut
2012-03-13 4:25 ` Wolfgang Denk
2012-03-13 4:50 ` Marek Vasut
2012-03-13 5:32 ` Graeme Russ
2012-03-13 2:03 ` Mike Frysinger
2012-03-14 1:38 ` [U-Boot] [PATCH V4] BOOT: Add "bootz" command to boot Linux zImage on ARM Marek Vasut
2012-03-14 2:03 ` Mike Frysinger
2012-03-14 2:40 ` Marek Vasut
2012-03-14 3:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204011602.44001.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox