From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 2 Apr 2012 05:36:40 +0200 Subject: [U-Boot] [PATCH] Prevent malloc with size 0 In-Reply-To: <201204012310.05235.vapier@gentoo.org> References: <4CC006B1.8000905@intracomdefense.com> <201204012310.05235.vapier@gentoo.org> Message-ID: <201204020536.40938.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Mike Frysinger, > On Sunday 01 April 2012 18:40:05 Graeme Russ wrote: > > if ((long)bytes == 0) { > > > > DEBUG("Warning: malloc of zero block size\n"); > > bytes = 1; > > > > } else if ((long)bytes < 0) { > > > > DEBUG("Error: malloc of negative block size\n"); > > return 0; > > > > } > > this should be (ssize_t) casts, not (long) This ain't the point of this, but you're right. > -mike Best regards, Marek Vasut