From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 1/4] ARM1136: add cache flush and invalidate operations
Date: Mon, 2 Apr 2012 18:29:45 +0200 [thread overview]
Message-ID: <201204021829.46104.marex@denx.de> (raw)
In-Reply-To: <1333383480-16028-1-git-send-email-sbabic@denx.de>
Dear Stefano Babic,
> From: Anatolij Gustschin <agust@denx.de>
>
> Since commit 5c1ad3e6f8ae578bbe30e09652f1531e9bc22031
> (net: fec_mxc: allow use with cache enabled) the FEC_MXC
> driver uses flush_dcache_range() and invalidate_dcache_range()
> functions. This driver is also configured for ARM1136 based
> 'flea3' and 'mx35pdk' boards which currently do not build
> as there are no ARM1136 specific flush_dcache_range() and
> invalidate_dcache_range() functions. Add various ARM1136
> cache functions to fix building for 'flea3' and 'mx35pdk'.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> CC: Mike Frysinger <vapier@gentoo.org>
> CC: Marek Vasut <marex@denx.de>
> ---
> arch/arm/cpu/arm1136/cpu.c | 95
> ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 95
> insertions(+), 0 deletions(-)
>
> Changes since V2:
> - use debug instead of printf in case of misalignment (M. Frysinger, M.
> Vasut)
>
> Changes since V1:
>
> - use the same routine as in ARM926ejs to check range to easy detect
> misalignment (S. Babic) - cache are still disable - add enable_caches (S.
> Babic)
Acked-by: Marek Vasut <marex@denx.de>
>
> diff --git a/arch/arm/cpu/arm1136/cpu.c b/arch/arm/cpu/arm1136/cpu.c
> index 2b91631..f2e30b5 100644
> --- a/arch/arm/cpu/arm1136/cpu.c
> +++ b/arch/arm/cpu/arm1136/cpu.c
> @@ -75,3 +75,98 @@ static void cache_flush(void)
> asm ("mcr p15, 0, %0, c7, c7, 0": :"r" (i)); /* invalidate both caches
> and flush btb */ asm ("mcr p15, 0, %0, c7, c10, 4": :"r" (i)); /* mem
> barrier to sync things */ }
> +
> +#ifndef CONFIG_SYS_DCACHE_OFF
> +
> +#ifndef CONFIG_SYS_CACHELINE_SIZE
> +#define CONFIG_SYS_CACHELINE_SIZE 32
> +#endif
> +
> +void invalidate_dcache_all(void)
> +{
> + asm ("mcr p15, 0, %0, c7, c6, 0" : : "r" (0));
> +}
> +
> +void flush_dcache_all(void)
> +{
> + asm ("mcr p15, 0, %0, c7, c10, 0" : : "r" (0));
> + asm ("mcr p15, 0, %0, c7, c10, 4" : : "r" (0));
> +}
> +
> +static inline int bad_cache_range(unsigned long start, unsigned long stop)
> +{
> + int ok = 1;
> +
> + if (start & (CONFIG_SYS_CACHELINE_SIZE - 1))
> + ok = 0;
> +
> + if (stop & (CONFIG_SYS_CACHELINE_SIZE - 1))
> + ok = 0;
> +
> + if (!ok)
> + debug("CACHE: Misaligned operation at range [%08lx, %08lx]\n",
> + start, stop);
> +
> + return ok;
> +}
> +
> +void invalidate_dcache_range(unsigned long start, unsigned long stop)
> +{
> + if (bad_cache_range(start, stop))
> + return;
> +
> + while (start < stop) {
> + asm ("mcr p15, 0, %0, c7, c6, 1" : : "r" (start));
> + start += CONFIG_SYS_CACHELINE_SIZE;
> + }
> +}
> +
> +void flush_dcache_range(unsigned long start, unsigned long stop)
> +{
> + if (bad_cache_range(start, stop))
> + return;
> +
> + while (start < stop) {
> + asm ("mcr p15, 0, %0, c7, c14, 1" : : "r" (start));
> + start += CONFIG_SYS_CACHELINE_SIZE;
> + }
> +
> + asm ("mcr p15, 0, %0, c7, c10, 4" : : "r" (0));
> +}
> +
> +void flush_cache(unsigned long start, unsigned long size)
> +{
> + flush_dcache_range(start, start + size);
> +}
> +
> +void enable_caches(void)
> +{
> +#ifndef CONFIG_SYS_ICACHE_OFF
> + icache_enable();
> +#endif
> +#ifndef CONFIG_SYS_DCACHE_OFF
> + dcache_enable();
> +#endif
> +}
> +
> +#else /* #ifndef CONFIG_SYS_DCACHE_OFF */
> +void invalidate_dcache_all(void)
> +{
> +}
> +
> +void flush_dcache_all(void)
> +{
> +}
> +
> +void invalidate_dcache_range(unsigned long start, unsigned long stop)
> +{
> +}
> +
> +void flush_dcache_range(unsigned long start, unsigned long stop)
> +{
> +}
> +
> +void flush_cache(unsigned long start, unsigned long size)
> +{
> +}
> +#endif /* #ifndef CONFIG_SYS_DCACHE_OFF */
next prev parent reply other threads:[~2012-04-02 16:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 14:02 [U-Boot] [PATCH] ARM1136: add cache flush and invalidate operations Anatolij Gustschin
2012-03-30 14:20 ` Stefano Babic
2012-03-30 14:35 ` Anatolij Gustschin
2012-03-30 15:04 ` Stefano Babic
2012-03-30 15:28 ` Marek Vasut
2012-03-30 15:42 ` Anatolij Gustschin
2012-03-30 15:58 ` Stefano Babic
2012-03-30 16:05 ` Marek Vasut
2012-03-30 16:16 ` Stefano Babic
2012-04-01 13:22 ` [U-Boot] [PATCH 1/4] " Stefano Babic
2012-04-01 13:22 ` [U-Boot] [PATCH 2/4] net: round up before calling flush_cache Stefano Babic
2012-04-01 13:46 ` Marek Vasut
2012-04-01 14:56 ` Stefano Babic
2012-04-01 15:35 ` Marek Vasut
2012-04-01 19:23 ` Mike Frysinger
2012-04-01 21:00 ` Marek Vasut
2012-04-02 1:38 ` Mike Frysinger
2012-04-02 1:44 ` Marek Vasut
2012-04-02 3:06 ` Mike Frysinger
2012-04-02 3:34 ` Marek Vasut
2012-04-02 5:56 ` Mike Frysinger
2012-04-02 7:13 ` Stefano Babic
2012-04-02 14:03 ` Marek Vasut
2012-04-02 14:38 ` Stefano Babic
2012-04-01 13:23 ` [U-Boot] [PATCH 3/4] mx35: flea3: fix when cache functions are linked Stefano Babic
2012-04-01 13:23 ` [U-Boot] [PATCH 4/4] mx35: mx35pdk: " Stefano Babic
2012-04-02 16:18 ` [U-Boot] [PATCH V3 1/4] ARM1136: add cache flush and invalidate operations Stefano Babic
2012-04-02 16:29 ` Marek Vasut [this message]
2012-04-02 16:51 ` Stefano Babic
2012-04-02 16:18 ` [U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses Stefano Babic
2012-04-02 16:29 ` Marek Vasut
2012-04-02 18:23 ` Mike Frysinger
2012-04-02 18:42 ` Marek Vasut
2012-04-02 19:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204021829.46104.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox