public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses
Date: Mon, 2 Apr 2012 18:29:55 +0200	[thread overview]
Message-ID: <201204021829.55536.marex@denx.de> (raw)
In-Reply-To: <1333383529-16064-1-git-send-email-sbabic@denx.de>

Dear Stefano Babic,

> Misaligned warnings are useful to debug faulty drivers.
> A misaligned warning is printed also when the driver
> is correct - use debug() instead of printf().
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Albert Aribaud <albert.u.boot@aribaud.net>
> CC: Mike Frysinger <vapier@gentoo.org>
> CC: Marek Vasut <marex@denx.de>

Acked-by: Marek Vasut <marex@denx.de>

> ---
> 
> Changes since V1:
> 
> This substitutes [PATCH 2/4] net: round up before calling flush_cache
> - change warning in cache.c instead of fixing cmd_net.c
> 	(M. Frysinger, M. Vasut)
> 
>  arch/arm/cpu/arm926ejs/cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/cache.c
> b/arch/arm/cpu/arm926ejs/cache.c index 5b23e3a..4430578 100644
> --- a/arch/arm/cpu/arm926ejs/cache.c
> +++ b/arch/arm/cpu/arm926ejs/cache.c
> @@ -55,7 +55,7 @@ static int check_cache_range(unsigned long start,
> unsigned long stop) ok = 0;
> 
>  	if (!ok)
> -		printf("CACHE: Misaligned operation at range [%08lx, %08lx]\n",
> +		debug("CACHE: Misaligned operation at range [%08lx, %08lx]\n",
>  			start, stop);
> 
>  	return ok;

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-02 16:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 14:02 [U-Boot] [PATCH] ARM1136: add cache flush and invalidate operations Anatolij Gustschin
2012-03-30 14:20 ` Stefano Babic
2012-03-30 14:35   ` Anatolij Gustschin
2012-03-30 15:04     ` Stefano Babic
2012-03-30 15:28       ` Marek Vasut
2012-03-30 15:42         ` Anatolij Gustschin
2012-03-30 15:58         ` Stefano Babic
2012-03-30 16:05           ` Marek Vasut
2012-03-30 16:16             ` Stefano Babic
2012-04-01 13:22 ` [U-Boot] [PATCH 1/4] " Stefano Babic
2012-04-01 13:22   ` [U-Boot] [PATCH 2/4] net: round up before calling flush_cache Stefano Babic
2012-04-01 13:46     ` Marek Vasut
2012-04-01 14:56       ` Stefano Babic
2012-04-01 15:35         ` Marek Vasut
2012-04-01 19:23     ` Mike Frysinger
2012-04-01 21:00       ` Marek Vasut
2012-04-02  1:38         ` Mike Frysinger
2012-04-02  1:44           ` Marek Vasut
2012-04-02  3:06             ` Mike Frysinger
2012-04-02  3:34               ` Marek Vasut
2012-04-02  5:56                 ` Mike Frysinger
2012-04-02  7:13       ` Stefano Babic
2012-04-02 14:03         ` Marek Vasut
2012-04-02 14:38           ` Stefano Babic
2012-04-01 13:23   ` [U-Boot] [PATCH 3/4] mx35: flea3: fix when cache functions are linked Stefano Babic
2012-04-01 13:23   ` [U-Boot] [PATCH 4/4] mx35: mx35pdk: " Stefano Babic
2012-04-02 16:18   ` [U-Boot] [PATCH V3 1/4] ARM1136: add cache flush and invalidate operations Stefano Babic
2012-04-02 16:29     ` Marek Vasut
2012-04-02 16:51     ` Stefano Babic
2012-04-02 16:18   ` [U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses Stefano Babic
2012-04-02 16:29     ` Marek Vasut [this message]
2012-04-02 18:23     ` Mike Frysinger
2012-04-02 18:42       ` Marek Vasut
2012-04-02 19:07         ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204021829.55536.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox