public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] MMC0: DMA transfer failed
Date: Mon, 2 Apr 2012 18:34:02 +0200	[thread overview]
Message-ID: <201204021834.02948.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAOMZO5Bzgis7WGyHOfV54oZN5GBe_YGAdCL6z3FRWM8ScsP_mw@mail.gmail.com>

Dear Fabio Estevam,

> On Mon, Apr 2, 2012 at 11:41 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > No, it means I might just have a good card and I didn't notice this. I
> > really do need to get some crappy (new) cards to track down these
> > issues. Fabio, can you please try debugging this?
> 
> Ok, I am debugging this.
> 
> What do you think about the change below?
> 
> --- a/drivers/mmc/mxsmmc.c
> +++ b/drivers/mmc/mxsmmc.c
> @@ -191,7 +191,7 @@ mxsmmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
> struct else
>                 cache_data_count = data_count;
> 
> -       if (data->flags & MMC_DATA_READ) {
> +       if (data->flags & MMC_DATA_WRITE) {
>                 priv->desc->cmd.data = MXS_DMA_DESC_COMMAND_DMA_WRITE;
>                 priv->desc->cmd.address = (dma_addr_t)data->dest;
>         } else {
> 
> It doesn't fix this issue, but it seems correct.

No it's not, when you do SD READ, you read the data into the dest buffer.

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-02 16:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 14:01 [U-Boot] MMC0: DMA transfer failed Fabio Estevam
2012-04-02 14:41 ` Marek Vasut
2012-04-02 15:40   ` Fabio Estevam
2012-04-02 16:34     ` Marek Vasut [this message]
2012-04-02 14:53 ` Stefano Babic
2012-04-02 15:01   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204021834.02948.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox