From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] MIPS: fix inconsistency in config option for cache operation mode
Date: Tue, 3 Apr 2012 15:40:08 +0200 [thread overview]
Message-ID: <201204031540.09067.marex@denx.de> (raw)
In-Reply-To: <1333371476-30691-3-git-send-email-daniel.schwierzeck@googlemail.com>
Mike, there was some issue with this patch?
> Commit ab2a98b11716364bc5a8c43cdfa7fee176cda1d8 missed to
> use the new config option in dcache_enable().
>
> Fix this to avoid inconsistencies if someone wants to disable
> and enable D-caches.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
> ---
> arch/mips/cpu/mips32/cache.S | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/mips/cpu/mips32/cache.S b/arch/mips/cpu/mips32/cache.S
> index 5ce0ec4..e683e8b 100644
> --- a/arch/mips/cpu/mips32/cache.S
> +++ b/arch/mips/cpu/mips32/cache.S
> @@ -30,6 +30,10 @@
> #include <asm/addrspace.h>
> #include <asm/cacheops.h>
>
> +#ifndef CONFIG_SYS_MIPS_CACHE_MODE
> +#define CONFIG_SYS_MIPS_CACHE_MODE CONF_CM_CACHABLE_NONCOHERENT
> +#endif
> +
> #define RA t8
>
> /*
> @@ -224,7 +228,7 @@ LEAF(dcache_enable)
> mfc0 t0, CP0_CONFIG
> ori t0, CONF_CM_CMASK
> xori t0, CONF_CM_CMASK
> - ori t0, CONF_CM_CACHABLE_NONCOHERENT
> + ori t0, CONFIG_SYS_MIPS_CACHE_MODE
> mtc0 t0, CP0_CONFIG
> jr ra
> END(dcache_enable)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-03 13:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 12:57 [U-Boot] [PATCH 0/3] MIPS: fixes for 2012.04-rc1 Daniel Schwierzeck
2012-04-02 12:57 ` [U-Boot] [PATCH 1/3] MIPS: board.c: fix init of flash data in bd_info Daniel Schwierzeck
2012-04-02 12:57 ` [U-Boot] [PATCH 2/3] MIPS: fix inconsistency in config option for cache operation mode Daniel Schwierzeck
2012-04-03 13:40 ` Marek Vasut [this message]
2012-04-03 15:49 ` Daniel Schwierzeck
2012-04-03 16:09 ` Marek Vasut
2012-04-03 20:33 ` Mike Frysinger
2012-04-04 3:01 ` Shinya Kuribayashi
2012-04-02 12:57 ` [U-Boot] [PATCH 3/3] MIPS: fix endianess handling Daniel Schwierzeck
2012-04-03 20:31 ` Mike Frysinger
2012-04-04 7:14 ` Marek Vasut
2012-04-02 13:56 ` [U-Boot] [PATCH 0/3] MIPS: fixes for 2012.04-rc1 Marek Vasut
2012-04-03 11:15 ` Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204031540.09067.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox