public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC v0 08/11] omap3: Consolidate UART information in omap3_common.h
Date: Tue, 3 Apr 2012 17:35:25 -0400	[thread overview]
Message-ID: <201204031735.26484.vapier@gentoo.org> (raw)
In-Reply-To: <1332443357-14062-9-git-send-email-trini@ti.com>

On Thursday 22 March 2012 15:09:14 Tom Rini wrote:
> Unless a board defines CONFIG_SERIAL_MULTI we assume it is using an
> on-module UART somewhere.  We leave the exact configuration per-board.
> 
> Start an environment section in omap3_common.h and default to allowing
> the environment to override console/ethaddr.  omap3_mvblx retains its
> behavior via opt-out.

not a big deal, but it seems like the env settings slipped in after the fact

> --- a/include/configs/omap3_common.h
> +++ b/include/configs/omap3_common.h
> 
> +/*
> + * Default serial port configuration is an NS16550-compatible UART.
> + * Boards can override this as needed with CONFIG_SERIAL_MULTI
> + */
> +#ifndef CONFIG_SERIAL_MULTI
> +#define CONFIG_SYS_NS16550
> +#define CONFIG_SYS_NS16550_SERIAL
> +#define CONFIG_SYS_NS16550_REG_SIZE	(-4)
> +#define CONFIG_SYS_NS16550_CLK		48000000
> +#define CONFIG_SYS_BAUDRATE_TABLE	{4800, 9600, 19200, 38400, 57600,\
> +					115200}
> +#endif

the baudrate table is fairly independent of the serial driver.  might want to 
split that out into its own ifndef/define/endif check.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120403/59b060b2/attachment.pgp>

  reply	other threads:[~2012-04-03 21:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 19:09 [U-Boot] [RFC v0 0/11]: Add <configs/omap3_common.h> Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 01/11] omap3+: Introduce <configs/omap3_common.h> Tom Rini
2012-03-23  1:48   ` Jason Kridner
2012-03-23 15:26     ` Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 02/11] omap3: Move DISPLAY_CPUINFO / DISPLAY_BOARDINFO to common Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 03/11] omap3: Move V_OSCK / V_SCLK to omap3_common.h Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 04/11] omap3: Move '#undef CONFIG_USE_IRQ' " Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 05/11] omap3: Move CONFIG_MISC_INIT_R " Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 06/11] omap3: Move ATAGS and OF_LIBFDT " Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 07/11] omap3: Move SYS_MALLOC_LEN and ENV_SIZE " Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 08/11] omap3: Consolidate UART information in omap3_common.h Tom Rini
2012-04-03 21:35   ` Mike Frysinger [this message]
2012-04-03 23:45     ` Tom Rini
2012-04-04  2:42       ` Mike Frysinger
2012-04-04 18:19         ` Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 09/11] omap3: Consolidate HSMMC support into omap3_common.h Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 10/11] omap3: Consolidate NAND information in omap3_common.h Tom Rini
2012-03-22 19:09 ` [U-Boot] [RFC v0 11/11] omap3: Consolidate I2C information into omap3_common.h Tom Rini
2012-04-03 21:37 ` [U-Boot] [RFC v0 0/11]: Add <configs/omap3_common.h> Mike Frysinger
2012-04-03 23:35   ` Tom Rini
2012-04-04  2:46     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204031735.26484.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox