From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9] usb: align buffers at cacheline
Date: Wed, 4 Apr 2012 10:01:46 +0200 [thread overview]
Message-ID: <201204041001.46847.marex@denx.de> (raw)
In-Reply-To: <1333445166-14184-1-git-send-email-puneets@nvidia.com>
Dear Puneet Saxena,
> This avoids cache-alignment warnings shown in console
> when a usb command is entered.
>
> Whenever X bytes of unaligned buffer is invalidated, arm core
> invalidates X + Y bytes as per the cache line size and throws
> these warnings.
>
> Signed-off-by: Puneet Saxena <puneets@nvidia.com>
> ---
I think we're almost there, hurray! :-)
Though on m28evk this still has issues:
=> usb reset
(Re)start USB...
USB: Register 10011 NbrPorts 1
USB EHCI 1.00
scanning bus for devices... EHCI timed out on TD - token=0x80008c80
EHCI timed out on TD - token=0x80008d80
EHCI timed out on TD - token=0x80008c80
EHCI timed out on TD - token=0x80008c80
EHCI timed out on TD - token=0x80008c80
ERROR: NOT USB_CONFIG_DESC 1
EHCI timed out on TD - token=0x80008d80
2 USB Device(s) found
scanning bus for storage devices... 0 Storage Device(s) found
I have a single USB pendrive connected to the board.
Also note, that if I disable the caches, it all works even with your patch
applied. So I suspect there's something even more to this (maybe broken
ehci_invalidate_dcache() ? ). Where did you test these patches?
Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-04 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 9:26 [U-Boot] [PATCH v9] usb: align buffers at cacheline Puneet Saxena
2012-04-04 8:01 ` Marek Vasut [this message]
2012-04-06 10:54 ` puneets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204041001.46847.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox