[U-Boot] [PATCH v3 0/4] ARM: EXYNOS: add display driver for EXYNOS SoC

[U-Boot] [PATCH v3 0/4] ARM: EXYNOS: add display driver for EXYNOS SoC

[Donghwa Lee]

This patch is for display driver version 3 of EXYNOS SoC.

[1/4]: 	ARM: EXYNOS: definition of system registers
	- to contorl FIMD of LBLK0 bypass selection, add missed 
	definitions of system register
[2/4]: 	ARM: EXYNOS:  add data structure for EXYNOS display driver
	- It is needed to specific vidinfo_t data structure for 
	EXYNOS display driver.
[3/4]: 	ARM: EXYNOS: add exynos lcd clock interface
	- Is is newly defined to interface to get lcd source clock.
[4/4]: ARM: EXYNOS: support EXYNOS display driver


change of v2: 
	- define missing function declaration
	- correct the wrong return value for some function
	- etc

Thank you,
Donghwa Lee

[U-Boot] [PATCH v3 0/4] ARM: EXYNOS: add display driver for EXYNOS SoC

[Minkyu Kang]

On 2 April 2012 17:39, Donghwa Lee <dh09.lee@samsung.com> wrote:
> This patch is for display driver version 3 of EXYNOS SoC.
>
> [1/4]: ?ARM: EXYNOS: definition of system registers
> ? ? ? ?- to contorl FIMD of LBLK0 bypass selection, add missed
> ? ? ? ?definitions of system register
> [2/4]: ?ARM: EXYNOS: ?add data structure for EXYNOS display driver
> ? ? ? ?- It is needed to specific vidinfo_t data structure for
> ? ? ? ?EXYNOS display driver.
> [3/4]: ?ARM: EXYNOS: add exynos lcd clock interface
> ? ? ? ?- Is is newly defined to interface to get lcd source clock.
> [4/4]: ARM: EXYNOS: support EXYNOS display driver
>
>
> change of v2:
> ? ? ? ?- define missing function declaration
> ? ? ? ?- correct the wrong return value for some function
> ? ? ? ?- etc
>

Donghwa,
Looks good to me.

Anatolij,
How you think about patch 2 and 4?

If you are OK, I will merge this patchset to samsung tree with your ACK.
Please send review to him or ACK to me.

Thanks.
Minkyu Kang.
-- 
from. prom.
www.promsoft.net

[U-Boot] [PATCH v3 0/4] ARM: EXYNOS: add display driver for EXYNOS SoC

[Anatolij Gustschin]

Hi!

On Wed, 4 Apr 2012 17:24:17 +0900
Minkyu Kang <promsoft@gmail.com> wrote:

> On 2 April 2012 17:39, Donghwa Lee <dh09.lee@samsung.com> wrote:
> > This patch is for display driver version 3 of EXYNOS SoC.
> >
> > [1/4]: ?ARM: EXYNOS: definition of system registers
> > ? ? ? ?- to contorl FIMD of LBLK0 bypass selection, add missed
> > ? ? ? ?definitions of system register
> > [2/4]: ?ARM: EXYNOS: ?add data structure for EXYNOS display driver
> > ? ? ? ?- It is needed to specific vidinfo_t data structure for
> > ? ? ? ?EXYNOS display driver.
> > [3/4]: ?ARM: EXYNOS: add exynos lcd clock interface
> > ? ? ? ?- Is is newly defined to interface to get lcd source clock.
> > [4/4]: ARM: EXYNOS: support EXYNOS display driver
> >
> >
> > change of v2:
> > ? ? ? ?- define missing function declaration
> > ? ? ? ?- correct the wrong return value for some function
> > ? ? ? ?- etc
> >
> 
> Donghwa,
> Looks good to me.
> 
> Anatolij,
> How you think about patch 2 and 4?
> 
> If you are OK, I will merge this patchset to samsung tree with your ACK.
> Please send review to him or ACK to me.

I've send my comments for patches 2 and 4, these patches look pretty
good, but need some minor fixing.

> Thanks.
> Minkyu Kang.

Thanks,
Anatolij

[U-Boot] [PATCH v3 0/4] ARM: EXYNOS: add display driver for EXYNOS SoC

[Donghwa Lee]

Hi,
I will modify as your comments.

On Wen, 04 Apr 2012 23:25, Anatolij Gustschin wrote:

> Hi!
> 
> On Wed, 4 Apr 2012 17:24:17 +0900
> Minkyu Kang <promsoft@gmail.com> wrote:
> 
>> On 2 April 2012 17:39, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>> This patch is for display driver version 3 of EXYNOS SoC.
>>>
>>> [1/4]:  ARM: EXYNOS: definition of system registers
>>>        - to contorl FIMD of LBLK0 bypass selection, add missed
>>>        definitions of system register
>>> [2/4]:  ARM: EXYNOS:  add data structure for EXYNOS display driver
>>>        - It is needed to specific vidinfo_t data structure for
>>>        EXYNOS display driver.
>>> [3/4]:  ARM: EXYNOS: add exynos lcd clock interface
>>>        - Is is newly defined to interface to get lcd source clock.
>>> [4/4]: ARM: EXYNOS: support EXYNOS display driver
>>>
>>>
>>> change of v2:
>>>        - define missing function declaration
>>>        - correct the wrong return value for some function
>>>        - etc
>>>
>>
>> Donghwa,
>> Looks good to me.
>>
>> Anatolij,
>> How you think about patch 2 and 4?
>>
>> If you are OK, I will merge this patchset to samsung tree with your ACK.
>> Please send review to him or ACK to me.
> 
> I've send my comments for patches 2 and 4, these patches look pretty
> good, but need some minor fixing.
> 
>> Thanks.
>> Minkyu Kang.
> 
> Thanks,
> Anatolij
>