From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 5 Apr 2012 02:48:31 +0200
Subject: [U-Boot] [PATCH] i.MX28: Enable SD DMA only if DCache enabled
In-Reply-To: <CAOMZO5Di5DD7PUsa+PJYdH3c9-7FWC69hr2Ef7Lc6FiYJBkUag@mail.gmail.com>
References: <1333576270-8477-1-git-send-email-marex@denx.de>
	<CAOMZO5Di5DD7PUsa+PJYdH3c9-7FWC69hr2Ef7Lc6FiYJBkUag@mail.gmail.com>
Message-ID: <201204050248.31903.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

> On Wed, Apr 4, 2012 at 6:51 PM, Marek Vasut <marex@denx.de> wrote:
> > +/* Enable DMA transfers only if DCache is on. */
> > +#ifndef CONFIG_SYS_DCACHE_OFF
> > +#define CONFIG_MXS_MMC_DMA
> > +#endif
> 
> Your patch makes sense, but I would prefer not to couple
> CONFIG_MXS_MMC_DMA with DCACHE support.
> 
> Someone may want to enable cache, but still uses MMC driver in PIO mode.

You don't, it's slow as crap then.

> IMHO CONFIG_MXS_MMC_DMA could be defined in configs/board.h when needed.
> 
> Yesterday I was running MMC DMA without DCACHE support and it did work
> (after the mxs_dma_init changes).

I have some obscure card now and I'm seeing breakage (DMA transfer timeout).

btw. Fabio, can you ping me on jabber please?

Best regards,
Marek Vasut