From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 5 Apr 2012 12:08:27 +0200
Subject: [U-Boot] [PATCH] i.MX28: Enable SD DMA only if DCache enabled
In-Reply-To: <CAOMZO5C5rL4gFDBC=P4EcUvuK2u1jCN5PHsDTqHQ4VYpd3MYYw@mail.gmail.com>
References: <1333576270-8477-1-git-send-email-marex@denx.de>
	<201204050248.31903.marex@denx.de>
	<CAOMZO5C5rL4gFDBC=P4EcUvuK2u1jCN5PHsDTqHQ4VYpd3MYYw@mail.gmail.com>
Message-ID: <201204051208.27893.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

> On Wed, Apr 4, 2012 at 9:48 PM, Marek Vasut <marex@denx.de> wrote:
> >> Someone may want to enable cache, but still uses MMC driver in PIO mode.
> > 
> > You don't, it's slow as crap then.
> 
> Well, this is how we have been using the MMC driver for the last 4 months.

With DCache disabled though ;-)

> I like the fact that your patch let PIO and DMA mode co-exist in the
> driver and that they are selectable by the CONFIG_MXS_MMC_DMA option.
> 
> What I really don?t like is that by enabling CONFIG_SYS_DCACHE_OFF you
> force CONFIG_MXS_MMC_DMA.

All right, agreed.

> These are separate things and one config option should not force the other.

Best regards,
Marek Vasut