From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: use noinline define
Date: Thu, 5 Apr 2012 12:13:21 +0200 [thread overview]
Message-ID: <201204051213.21759.marek.vasut@gmail.com> (raw)
In-Reply-To: <1333601093-21481-1-git-send-email-vapier@gentoo.org>
Dear Mike Frysinger,
> Building usb for Blackfin boards fails as we get linux/compiler.h
> included which expands the "noinline" inside of the attribute and
> we get attribute(attribute(noinline)).
>
> Explicitly use the helper define to avoid this.
Ain't compiler.h broken then? Btw. is this a fix I should push to .04 release?
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> common/usb.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/common/usb.c b/common/usb.c
> index 1ec30bc..71b4b2b 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -47,6 +47,7 @@
> #include <common.h>
> #include <command.h>
> #include <asm/processor.h>
> +#include <linux/compiler.h>
> #include <linux/ctype.h>
> #include <asm/byteorder.h>
> #include <asm/unaligned.h>
> @@ -261,7 +262,7 @@ int usb_maxpacket(struct usb_device *dev, unsigned long
> pipe) *
> * NOTE: Similar behaviour was observed with GCC4.6 on ARMv5.
> */
> -static void __attribute__((noinline))
> +static void noinline
> usb_set_maxpacket_ep(struct usb_device *dev, int if_idx, int ep_idx)
> {
> int b;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-05 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 4:44 [U-Boot] [PATCH] usb: use noinline define Mike Frysinger
2012-04-05 10:13 ` Marek Vasut [this message]
2012-04-05 17:42 ` Mike Frysinger
2012-04-05 19:19 ` Marek Vasut
2012-04-05 19:29 ` Mike Frysinger
2012-04-05 20:24 ` Marek Vasut
2012-04-05 20:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204051213.21759.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox