From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Thu, 5 Apr 2012 12:13:21 +0200
Subject: [U-Boot] [PATCH] usb: use noinline define
In-Reply-To: <1333601093-21481-1-git-send-email-vapier@gentoo.org>
References: <1333601093-21481-1-git-send-email-vapier@gentoo.org>
Message-ID: <201204051213.21759.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Mike Frysinger,

> Building usb for Blackfin boards fails as we get linux/compiler.h
> included which expands the "noinline" inside of the attribute and
> we get attribute(attribute(noinline)).
> 
> Explicitly use the helper define to avoid this.

Ain't compiler.h broken then? Btw. is this a fix I should push to .04 release?

> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  common/usb.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/common/usb.c b/common/usb.c
> index 1ec30bc..71b4b2b 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -47,6 +47,7 @@
>  #include <common.h>
>  #include <command.h>
>  #include <asm/processor.h>
> +#include <linux/compiler.h>
>  #include <linux/ctype.h>
>  #include <asm/byteorder.h>
>  #include <asm/unaligned.h>
> @@ -261,7 +262,7 @@ int usb_maxpacket(struct usb_device *dev, unsigned long
> pipe) *
>   * NOTE: Similar behaviour was observed with GCC4.6 on ARMv5.
>   */
> -static void  __attribute__((noinline))
> +static void noinline
>  usb_set_maxpacket_ep(struct usb_device *dev, int if_idx, int ep_idx)
>  {
>  	int b;

Best regards,
Marek Vasut