From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: use noinline define
Date: Thu, 5 Apr 2012 21:19:11 +0200 [thread overview]
Message-ID: <201204052119.11557.marek.vasut@gmail.com> (raw)
In-Reply-To: <201204051342.47692.vapier@gentoo.org>
Dear Mike Frysinger,
> On Thursday 05 April 2012 06:13:21 Marek Vasut wrote:
> > Dear Mike Frysinger,
> >
> > > Building usb for Blackfin boards fails as we get linux/compiler.h
> > > included which expands the "noinline" inside of the attribute and
> > > we get attribute(attribute(noinline)).
> > >
> > > Explicitly use the helper define to avoid this.
> >
> > Ain't compiler.h broken then?
>
> no ... why would it be ?
Because it colides with gcc stuff?
> > Btw. is this a fix I should push to .04 release?
>
> i looked closer at how exactly it's failing, and i think waiting for the
> next merge window is OK if you want
I'm fine either way as I don't observe this. On the other hand, I'd be inclined
to push this into current release if you're 100% sure about the fix and it fixes
real issue for some people.
> -mike
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-05 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 4:44 [U-Boot] [PATCH] usb: use noinline define Mike Frysinger
2012-04-05 10:13 ` Marek Vasut
2012-04-05 17:42 ` Mike Frysinger
2012-04-05 19:19 ` Marek Vasut [this message]
2012-04-05 19:29 ` Mike Frysinger
2012-04-05 20:24 ` Marek Vasut
2012-04-05 20:35 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204052119.11557.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox