From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole
Date: Sun, 8 Apr 2012 04:26:41 -0400 [thread overview]
Message-ID: <201204080426.42730.vapier@gentoo.org> (raw)
In-Reply-To: <CANr=Z=Y-ma=CNuW55FC_Z2a=6Cnw2iW9SiythpsupVipnFN8hA@mail.gmail.com>
On Wednesday 04 April 2012 11:27:44 Joe Hershberger wrote:
> On Tue, Apr 3, 2012 at 3:54 PM, Sebastian Andrzej Siewior wrote:
> > On 04/03/2012 10:42 PM, Mike Frysinger wrote:
> >> On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote:
> >>> --- a/drivers/net/tsec.c
> >>> +++ b/drivers/net/tsec.c
> >>>
> >>> + if (strcmp(getenv("stdout"), "nc"))
> >>
> >> i really don't like special casing devices like this
>
> In this case I think it is better to check if stdout is nc, but not to
> explicitly write to serial_printf(). The nc device is the reason to
> avoid printing this since it uses the network. The serial_printf
> seems like the special case to avoid. Consider the case of using a
> SPI UART. There is no reason these traces should not go to it via the
> normal printf routing.
my point is that this doesn't scale ... not even close. either drop the
printf calls in the core net case (when it'd be a problem with the
netconsole), or figure out a solution that does actually scale. maybe a
net_printf().
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120408/d8e26af1/attachment.pgp>
next prev parent reply other threads:[~2012-04-08 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 20:11 [U-Boot] [PATCH 1/3] net/eth: set status to active before calling init Sebastian Andrzej Siewior
2012-03-23 20:11 ` [U-Boot] [PATCH 2/3] net/tsec: convert the printf() to serial_printf() Sebastian Andrzej Siewior
2012-03-23 20:11 ` [U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole Sebastian Andrzej Siewior
2012-04-03 20:42 ` Mike Frysinger
2012-04-03 20:54 ` Sebastian Andrzej Siewior
2012-04-04 15:27 ` Joe Hershberger
2012-04-08 8:26 ` Mike Frysinger [this message]
2012-04-09 21:43 ` Joe Hershberger
2012-04-03 20:41 ` [U-Boot] [PATCH 1/3] net/eth: set status to active before calling init Mike Frysinger
2012-04-03 20:51 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204080426.42730.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox