public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled
Date: Mon, 9 Apr 2012 09:41:10 +0200	[thread overview]
Message-ID: <201204090941.10587.marex@denx.de> (raw)
In-Reply-To: <4F8290B2.3@nvidia.com>

Dear puneets,

> Dear Marek,
> After applying these 4 patches I don't see any alignment spew and it
> detects the
> mass storage device perfectly though I see a warning "EHCI timed out on
> TD - token=0x80008c80"
> consistently in each "usb reset".

That's something else (unrelated to this patchset), I saw it in your backlog 
too. Can you try debuging it on top of these patches? Because these patches fix 
a lot of other issues, so let's take them as a base for now. Also, did you 
really test dos partition table and vfat? I had to fix them to work with 
patches, you change to part_dos.c wasn't enough.

> 
> Thanx & Regards,
> Puneet
> 
> On Monday 09 April 2012 08:42 AM, Marek Vasut wrote:
> > Dear Marek Vasut,
> > 
> >> This patchset reworks the USB core and EHCI-HCD to work with data
> >> caches.
> >> 
> >> Marek Vasut (3):
> >>    USB: Drop ehci_alloc/ehci_free in ehci-hcd
> >>    USB: Drop cache flush bloat in EHCI-HCD
> >>    USB: Document the QH and qTD antics in EHCI-HCD
> >> 
> >> Puneet Saxena (1):
> >>    USB: Align buffers at cacheline
> >>   
> >>   common/cmd_usb.c            |    3 +-
> >>   common/usb.c                |   22 ++--
> >>   common/usb_hub.c            |   27 ++--
> >>   common/usb_storage.c        |   59 +++++-----
> >>   disk/part_dos.c             |    2 +-
> >>   drivers/usb/host/ehci-hcd.c |  284
> >> 
> >> ++++++++++++++----------------------------- include/scsi.h             
> >> |
> >> 
> >>    4 +-
> >>   
> >>   include/usb.h               |    4 +-
> >>   8 files changed, 155 insertions(+), 250 deletions(-)
> >> 
> >> Cc: Puneet Saxena<puneets@nvidia.com>
> > 
> > Puneet, can you please test this stuff? It should fix your cache
> > misalignment issues. Mine are now gone and USB works with caches on too.
> > 
> > I'd like to queue this for -next.
> > 
> > Best regards,
> > Marek Vasut
> 
> ---------------------------------------------------------------------------
> -------- This email message is for the sole use of the intended
> recipient(s) and may contain confidential information.  Any unauthorized
> review, use, disclosure or distribution is prohibited.  If you are not the
> intended recipient, please contact the sender by reply email and destroy
> all copies of the original message.
> ---------------------------------------------------------------------------
> --------

Best regards,
Marek Vasut

      reply	other threads:[~2012-04-09  7:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09  3:09 [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 1/4] USB: Align buffers at cacheline Marek Vasut
2012-04-09  4:49   ` [U-Boot] [PATCH 1/4 V2] " Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 2/4] USB: Drop ehci_alloc/ehci_free in ehci-hcd Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 3/4] USB: Drop cache flush bloat in EHCI-HCD Marek Vasut
2012-04-09  4:47   ` [U-Boot] [PATCH 3/4 V2] " Marek Vasut
2012-05-24  6:57     ` Anatolij Gustschin
2012-05-24 13:21       ` Marek Vasut
2012-05-29  8:24         ` Liu Gang
2012-05-29  8:36           ` Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 4/4] USB: Document the QH and qTD antics " Marek Vasut
2012-04-27  5:31   ` Mike Frysinger
2012-04-09  3:12 ` [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled Marek Vasut
2012-04-09  7:33   ` puneets
2012-04-09  7:41     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204090941.10587.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox