From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 9 Apr 2012 09:41:10 +0200
Subject: [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache
	enabled
In-Reply-To: <4F8290B2.3@nvidia.com>
References: <1333940992-15484-1-git-send-email-marex@denx.de>
	<201204090512.33178.marex@denx.de> <4F8290B2.3@nvidia.com>
Message-ID: <201204090941.10587.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear puneets,

> Dear Marek,
> After applying these 4 patches I don't see any alignment spew and it
> detects the
> mass storage device perfectly though I see a warning "EHCI timed out on
> TD - token=0x80008c80"
> consistently in each "usb reset".

That's something else (unrelated to this patchset), I saw it in your backlog 
too. Can you try debuging it on top of these patches? Because these patches fix 
a lot of other issues, so let's take them as a base for now. Also, did you 
really test dos partition table and vfat? I had to fix them to work with 
patches, you change to part_dos.c wasn't enough.

> 
> Thanx & Regards,
> Puneet
> 
> On Monday 09 April 2012 08:42 AM, Marek Vasut wrote:
> > Dear Marek Vasut,
> > 
> >> This patchset reworks the USB core and EHCI-HCD to work with data
> >> caches.
> >> 
> >> Marek Vasut (3):
> >>    USB: Drop ehci_alloc/ehci_free in ehci-hcd
> >>    USB: Drop cache flush bloat in EHCI-HCD
> >>    USB: Document the QH and qTD antics in EHCI-HCD
> >> 
> >> Puneet Saxena (1):
> >>    USB: Align buffers at cacheline
> >>   
> >>   common/cmd_usb.c            |    3 +-
> >>   common/usb.c                |   22 ++--
> >>   common/usb_hub.c            |   27 ++--
> >>   common/usb_storage.c        |   59 +++++-----
> >>   disk/part_dos.c             |    2 +-
> >>   drivers/usb/host/ehci-hcd.c |  284
> >> 
> >> ++++++++++++++----------------------------- include/scsi.h             
> >> |
> >> 
> >>    4 +-
> >>   
> >>   include/usb.h               |    4 +-
> >>   8 files changed, 155 insertions(+), 250 deletions(-)
> >> 
> >> Cc: Puneet Saxena<puneets@nvidia.com>
> > 
> > Puneet, can you please test this stuff? It should fix your cache
> > misalignment issues. Mine are now gone and USB works with caches on too.
> > 
> > I'd like to queue this for -next.
> > 
> > Best regards,
> > Marek Vasut
> 
> ---------------------------------------------------------------------------
> -------- This email message is for the sole use of the intended
> recipient(s) and may contain confidential information.  Any unauthorized
> review, use, disclosure or distribution is prohibited.  If you are not the
> intended recipient, please contact the sender by reply email and destroy
> all copies of the original message.
> ---------------------------------------------------------------------------
> --------

Best regards,
Marek Vasut