From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] add zip command support for uboot
Date: Tue, 10 Apr 2012 18:11:11 -0400 [thread overview]
Message-ID: <201204101811.12592.vapier@gentoo.org> (raw)
In-Reply-To: <CALZhoSQMg-jikxyPoxC7dBTQHd6-abBqGCjMNhJiAzXgCTnXZQ@mail.gmail.com>
On Tuesday 10 April 2012 01:05:13 Lei Wen wrote:
> Hi Mike,
>
> On Tue, Apr 10, 2012 at 12:37 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Tuesday 03 April 2012 05:31:09 Lei Wen wrote:
> >> Hi Mike,
> >>
> >> On Tue, Apr 3, 2012 at 3:17 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> >> > On Tue, Mar 27, 2012 at 04:04, Lei Wen <adrian.wenl@gmail.com> wrote:
> >> >> On Sun, Mar 25, 2012 at 11:53 PM, <adrian.wenl@gmail.com> wrote:
> >> >>> From: Lei Wen <leiwen@marvell.com>
> >> >>>
> >> >>> This patch set add zip command support for uboot.
> >> >>> The first two patches import deflate and trees functions from zlib
> >> >>> 1.2.5 without any change. While the third patch did the necessary
> >> >>> change to make the import file could be built passed in uboot
> >> >>> environment.
> >> >>
> >> >> Any comments to this series?
> >> >
> >> > did you forward port the misc fixes/optimization that were done ? or
> >> > did you just drop in the new code ?
> >>
> >> The fixes/optimization is already separated in different patch, as the
> >> 0004 in current series.
> >> Other file is just import as intact from zlib1.2.5, the 0001 and 0002
> >> patch.
> >
> > i don't understand what you mean. 0004 is "lib: zlib: remove the
> > limitation for cannot using 0 as start" and doesn't look like a fix that
> > was merged before.
> >
> >> > for example, cd514aeb996e2f7aefbe1f78481965d9d074aed4 is pretty
> >> > important
> >>
> >> I see. I try my best to keep the current modification history adding
> >> to the original zlib code.
> >
> > so you have maintained the bug fixes / optimizations ? it isn't clear in
> > your response (at least to me).
>
> I see what your concerns...
> Yes, this change is not included in the zlib's own code, but just
> added by myself.
> Without this change, in uboot, we cannot zip from the start of ddr
> memory, since many
> platforms, at least from what I saw, their start ddr memory address is from
> 0.
i think you've missed the point of my questions. we aren't concerned with
changes you've written (such as patch 4/6 in this series), but bug fixes that
were added to the zlib code before you updated things. updating to a newer
version and dropping previous fixes/optimizations isn't acceptable.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120410/d8c5e077/attachment.pgp>
next prev parent reply other threads:[~2012-04-10 22:11 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-25 15:53 [U-Boot] [PATCH 0/6] add zip command support for uboot adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 1/6] lib: zlib: import deflate source file from 1.2.5 adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 2/6] lib: zlib: import trees " adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 3/6] lib: zlib: include deflate into zlib build adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 4/6] lib: zlib: remove the limitation for cannot using 0 as start adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 5/6] lib: add gzip lib function callback adrian.wenl at gmail.com
2012-03-25 15:53 ` [U-Boot] [PATCH 6/6] common: add zip command support adrian.wenl at gmail.com
2012-03-27 8:04 ` [U-Boot] [PATCH 0/6] add zip command support for uboot Lei Wen
2012-03-27 18:12 ` Tom Rini
2012-03-28 2:23 ` Lei Wen
2012-04-02 14:16 ` Lei Wen
2012-04-02 19:17 ` Mike Frysinger
2012-04-03 9:31 ` Lei Wen
2012-04-10 4:37 ` Mike Frysinger
2012-04-10 5:05 ` Lei Wen
2012-04-10 22:11 ` Mike Frysinger [this message]
2012-04-11 1:24 ` Lei Wen
2012-05-08 12:57 ` Lei Wen
2012-06-21 19:12 ` Wolfgang Denk
2012-09-06 4:18 ` Marek Vasut
2012-09-06 4:49 ` Lei Wen
2012-09-06 6:23 ` Marek Vasut
2012-09-06 8:18 ` Lukasz Majewski
2012-09-06 8:49 ` Marek Vasut
2012-09-06 10:41 ` Lukasz Majewski
2012-09-06 10:49 ` Marek Vasut
2012-09-26 6:41 ` Lei Wen
2012-09-26 15:34 ` Marek Vasut
2012-09-26 16:20 ` Tom Rini
2012-09-27 2:05 ` Lei Wen
2012-09-27 15:22 ` Tom Rini
2012-09-28 14:29 ` Lei Wen
2012-09-27 2:12 ` Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 " Lei Wen
2012-09-29 14:51 ` Tom Rini
2012-09-28 14:26 ` [U-Boot] [PATCH V2 1/6] lib: zlib: import deflate source file from 1.2.5 Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 2/6] lib: zlib: import trees " Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 3/6] lib: zlib: include deflate into zlib build Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 4/6] lib: zlib: remove the limitation for cannot using 0 as start Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 5/6] lib: add gzip lib function callback Lei Wen
2012-09-28 14:26 ` [U-Boot] [PATCH V2 6/6] common: add zip command support Lei Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204101811.12592.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox