public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabresd: Add basic support
Date: Wed, 11 Apr 2012 21:49:25 +0200	[thread overview]
Message-ID: <20120411194925.26CEC200239@gemini.denx.de> (raw)
In-Reply-To: <1334158122-15219-1-git-send-email-festevam@gmail.com>

Dear Fabio Estevam,

In message <1334158122-15219-1-git-send-email-festevam@gmail.com> you wrote:
> Add basic support for mx6qsabresd board.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Could you please add a bit information which sort of board this is,
where to find documetnation about it, etc.?

> +#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
> +#define CONFIG_SYS_PROMPT              "MX6QSABRESD U-Boot > "

Do we really need such verbose prompts?  This appears to be overkill,
and is becoming more and more a nuisance. [I wonder when I will see
the first board which puts the full version string in the prompt :-( ]

> +#define CONFIG_SYS_MEMTEST_START       0x10000000
> +#define CONFIG_SYS_MEMTEST_END         0x10010000

Does this make sense?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you think the problem is bad now, just wait until we've solved it.
                                                        Epstein's Law

  reply	other threads:[~2012-04-11 19:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 15:28 [U-Boot] [PATCH] mx6qsabresd: Add basic support Fabio Estevam
2012-04-11 19:49 ` Wolfgang Denk [this message]
2012-04-11 20:15   ` Fabio Estevam
2012-04-11 21:36     ` Wolfgang Denk
2012-04-13 15:56       ` Fabio Estevam
2012-04-13 16:14         ` Dirk Behme
2012-04-13 22:36           ` Fabio Estevam
2012-04-13 23:04             ` Fabio Estevam
2012-04-14  5:36               ` Dirk Behme
2012-04-14 14:41               ` stefano babic
2012-04-14 15:24                 ` Fabio Estevam
2012-04-14 15:28                   ` Fabio Estevam
2012-04-14 16:00                     ` stefano babic
2012-04-14 20:15                       ` Wolfgang Denk
2012-04-15  8:56                         ` stefano babic
2012-04-14 20:14                   ` Wolfgang Denk
2012-04-14 20:13                 ` Wolfgang Denk
2012-04-15  9:02                   ` stefano babic
2012-07-11  6:23                     ` Dirk Behme
2012-07-11  8:08                       ` Fabio Estevam
2012-04-12  8:23   ` Marek Vasut
2012-04-12 10:52 ` Stefano Babic
2012-09-11  3:56   ` Fabio Estevam
2012-09-11  4:27     ` stefano babic
2012-09-11  5:39     ` Dirk Behme
2012-09-11 14:43     ` Eric Nelson
2012-09-11 15:07       ` Otavio Salvador
2012-09-11 22:10       ` stefano babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120411194925.26CEC200239@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox