From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 12 Apr 2012 10:23:36 +0200
Subject: [U-Boot] [PATCH] mx6qsabresd: Add basic support
In-Reply-To: <20120411194925.26CEC200239@gemini.denx.de>
References: <1334158122-15219-1-git-send-email-festevam@gmail.com>
	<20120411194925.26CEC200239@gemini.denx.de>
Message-ID: <201204121023.36757.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Fabio Estevam,
> 
> In message <1334158122-15219-1-git-send-email-festevam@gmail.com> you wrote:
> > Add basic support for mx6qsabresd board.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Could you please add a bit information which sort of board this is,
> where to find documetnation about it, etc.?
> 
> > +#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
> > +#define CONFIG_SYS_PROMPT              "MX6QSABRESD U-Boot > "
> 
> Do we really need such verbose prompts?  This appears to be overkill,
> and is becoming more and more a nuisance. [I wonder when I will see
> the first board which puts the full version string in the prompt :-( ]

MX28EVK rev. D with U-Boot v2012.04-rc2 00025-g7ae6af4-dirty (Apr 12 2012 - 
05:36:01) >>> # _

;-D

> 
> > +#define CONFIG_SYS_MEMTEST_START       0x10000000
> > +#define CONFIG_SYS_MEMTEST_END         0x10010000
> 
> Does this make sense?

It probably does, it runs memtest on a small piece of memory.

> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut