From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 16 Apr 2012 11:41:28 +0200
Subject: [U-Boot] [PATCH] usb:udc:samsung Add functions for storing
	private gadget data in UDC driver
In-Reply-To: <20120416113320.6a8a900c@lmajewski.digital.local>
References: <1334214969-19664-1-git-send-email-l.majewski@samsung.com>
	<201204141148.33492.marex@denx.de>
	<20120416113320.6a8a900c@lmajewski.digital.local>
Message-ID: <201204161141.29114.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Lukasz Majewski,

> Hi Marek Vasut,
> 
> > Dear Lukasz Majewski,
> > 
> > > This commit adds support for storing private data to Samsung's UDC
> > > driver. This data is afterward used by usb gadget.
> > > 
> > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > Cc: Marek Vasut <marex@denx.de>
> > > ---
> > > 
> > >  drivers/usb/gadget/s3c_udc_otg.c |   12 ++++++++++++
> > >  1 files changed, 12 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/drivers/usb/gadget/s3c_udc_otg.c
> > > b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..cb4916c 100644
> > > --- a/drivers/usb/gadget/s3c_udc_otg.c
> > > +++ b/drivers/usb/gadget/s3c_udc_otg.c
> > > @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int
> > > status); static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
> > > 
> > >  static void s3c_udc_set_nak(struct s3c_ep *ep);
> > > 
> > > +void set_udc_gadget_private_data(void *p)
> > > +{
> > > +	printf("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> > > +	       the_controller, p);
> > > +	the_controller->gadget.dev.device_data = p;
> > > +}
> > > +
> > > +void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> > > +{
> > > +	return gadget->dev.device_data;
> > > +}
> > > +
> > 
> > Is this part of some bigger patchset or are you simply adding dead
> > code?
> 
> Yes, this is the part of a bigger patchset :-) - the composite gadget
> (g_dnl) requires this change.
> 
> e.g.
> 
> http://patchwork.ozlabs.org/patch/151989/

Can you please make it into a patchset then? You know -- so we all know what 
this is part of.

> 
> > >  static struct usb_ep_ops s3c_ep_ops = {
> > >  
> > >  	.enable = s3c_ep_enable,
> > >  	.disable = s3c_ep_disable,
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut