public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/mtd/onenand/onenand_base.c: fix build warning
Date: Tue, 17 Apr 2012 13:15:41 +0200	[thread overview]
Message-ID: <20120417131541.6f324a0a@lmajewski.digital.local> (raw)
In-Reply-To: <1334593850-26270-1-git-send-email-agust@denx.de>

Hi Anatolij,

> Fix:
> onenand_base.c: In function 'onenand_probe':
> onenand_base.c:2577:6: warning: variable 'maf_id' set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> ---
>  drivers/mtd/onenand/onenand_base.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/onenand_base.c
> b/drivers/mtd/onenand/onenand_base.c index 480ae7a..229682c 100644
> --- a/drivers/mtd/onenand/onenand_base.c
> +++ b/drivers/mtd/onenand/onenand_base.c
> @@ -2574,7 +2574,7 @@ static int onenand_chip_probe(struct mtd_info
> *mtd) int onenand_probe(struct mtd_info *mtd)
>  {
>  	struct onenand_chip *this = mtd->priv;
> -	int maf_id, dev_id, ver_id;
> +	int dev_id, ver_id;
>  	int density;
>  	int ret;
>  
> @@ -2583,7 +2583,6 @@ int onenand_probe(struct mtd_info *mtd)
>  		return ret;
>  
>  	/* Read manufacturer and device IDs from Register */
> -	maf_id = this->read_word(this->base +
> ONENAND_REG_MANUFACTURER_ID); dev_id = this->read_word(this->base +
> ONENAND_REG_DEVICE_ID); ver_id = this->read_word(this->base +
> ONENAND_REG_VERSION_ID); this->technology =
> this->read_word(this->base + ONENAND_REG_TECHNOLOGY);

Is this a regression for -rc or the current master branch (recently
Wolfgang has pull some onenand related code)?


-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center
Platform Group

  reply	other threads:[~2012-04-17 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 16:30 [U-Boot] [PATCH] drivers/mtd/onenand/onenand_base.c: fix build warning Anatolij Gustschin
2012-04-17 11:15 ` Lukasz Majewski [this message]
2012-04-17 11:50   ` Anatolij Gustschin
2012-04-17 12:32     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120417131541.6f324a0a@lmajewski.digital.local \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox