public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU halt when missing USB PHY clock
Date: Thu, 19 Apr 2012 00:57:04 +0200	[thread overview]
Message-ID: <201204190057.04588.marex@denx.de> (raw)
In-Reply-To: <CAKWjMd7MNTt9G3m=7=aoioJP5=+mzaV_bXtOHPtmTnVmb=RHRQ@mail.gmail.com>

Dear Andy Fleming,

> Pinging you on this, again. Also, I've now moved the patch to Marek's
> queue, instead of mine.

Thanks! Did the FSL silicon team respond already?

> 
> On Sun, Feb 26, 2012 at 8:44 PM, Liu Shengzhou-B36685
> 
> <B36685@freescale.com> wrote:
> >> -----Original Message-----
> >> From: Marek Vasut [mailto:marex at denx.de]
> >> Sent: Monday, February 27, 2012 7:13 AM
> >> To: u-boot at lists.denx.de
> >> Cc: Liu Shengzhou-B36685
> >> Subject: Re: [U-Boot] [PATCH] powerpc/usb: fix bug of CPU halt when
> >> missing USB PHY clock
> >> 
> >> > when missing USB PHY clock and issuing "usb start" at u-boot prompt,
> >> > writing to or_portsc register will cause CPU halt. We should check
> >> > USBGP[PHY_CLK_VALID] bit at the first time in ehci_hcd_init() to
> >> 
> >> avoid
> >> 
> >> > CPU hang in this case.
> >> > 
> >> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> >> > ---
> >> >  drivers/usb/host/ehci-fsl.c |   22 +++++++++++++++++++---
> >> >  1 files changed, 19 insertions(+), 3 deletions(-)
> >> 
> >> Hi,
> >> 
> >> what's the status of this patch/patchset?
> >> 
> >> Thanks
> >> M
> > 
> > Currently we found that usb CTRL_PHY_CLK_VALID bit breaks on P1022
> > platform, which not contains this bit. - P1023/P3041/P5020 etc, have
> > this bit
> >  - P3060/4080/PSC913x do have this bit, but not mentioned in RM.
> >  - P1022(perhaps and other) has no this bit
> > I'm waiting for the response from FSL silicon team to confirm whether
> > there is other platform not including this bit or not, so this patch
> > maybe have to be pending until I get confirmation.
> > 
> > Thanks,
> > Shengzhou
> > 
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-18 22:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01  8:31 [U-Boot] [PATCH] powerpc/usb: fix bug of CPU halt when missing USB PHY clock Shengzhou Liu
2012-02-26 23:12 ` Marek Vasut
2012-02-27  2:44   ` Liu Shengzhou-B36685
2012-04-18 22:49     ` Andy Fleming
2012-04-18 22:57       ` Marek Vasut [this message]
2012-04-19  7:32         ` Liu Shengzhou-B36685
2012-04-19  8:24           ` Marek Vasut
2012-10-16  6:23           ` Marek Vasut
2012-10-18  3:40             ` Liu Shengzhou-B36685

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204190057.04588.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox