public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND 2/2] mmc:fix Call mmc_init() when executing mmc_get_dev()
Date: Fri, 20 Apr 2012 09:09:52 +0200	[thread overview]
Message-ID: <20120420090952.60c82296@lmajewski.digital.local> (raw)
In-Reply-To: <CALZhoSSfioNfHYyUQAo+w7zutvk7fO6WCtOS+p1jOZqGsTwGmA@mail.gmail.com>

Hi, Lei

> I'm concerning with this adding init here.
> Since not every platform mount with emmc as boot device, and what they
> need is booting fast. 

If I remember correctly, u-boot policy is to not initialize the mmc
until it is needed (i.e. command is executed).
So the extra init won't be executed until fatls or mmc is executed.

> If you order them to initialize all mmc/sd at
> mmc register stage, this adding booting time may not be the one they
> want to see.

I think that booting time will not increase, because in the mmc_init()
there is a check:

	if (mmc->has_init)
		return 0;

To prevent multiple register level initialization.

The execution time increase is boiled down to executing a
few instructions (when mmc->has_init is set).


-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center
Platform Group

  reply	other threads:[~2012-04-20  7:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19 12:39 [U-Boot] [RESEND 0/2] mmc:fix: MMC fixes for generic mmc driver running at GONI Lukasz Majewski
2012-04-19 12:39 ` [U-Boot] [RESEND 1/2] mmc:fix: Set mmc width according to MMC host capabilities Lukasz Majewski
2012-04-19 14:27   ` Lei Wen
2012-04-19 12:39 ` [U-Boot] [RESEND 2/2] mmc:fix Call mmc_init() when executing mmc_get_dev() Lukasz Majewski
2012-04-19 14:23   ` Lei Wen
2012-04-20  7:09     ` Lukasz Majewski [this message]
2012-04-21  8:39       ` Lei Wen
2012-05-08 22:33       ` Andy Fleming
2012-05-09  8:03         ` Lukasz Majewski
2012-04-25  7:38 ` [U-Boot] [RESEND 0/2] mmc:fix: MMC fixes for generic mmc driver running at GONI Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120420090952.60c82296@lmajewski.digital.local \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox