public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci-omap: fix for enabling the correct usb port
Date: Fri, 20 Apr 2012 08:24:22 -0700	[thread overview]
Message-ID: <20120420152422.GA23731@bill-the-cat> (raw)
In-Reply-To: <4F911376.1060104@denx.de>

On Fri, Apr 20, 2012 at 09:42:46AM +0200, Stefano Babic wrote:
> On 20/04/2012 00:42, Tom Rini wrote:
> > On Thu, Apr 19, 2012 at 11:25:18PM +0200, Jeroen Hofstee wrote:
> >> This is just a patch for the problem reported here:
> >> http://lists.denx.de/pipermail/u-boot/2012-February/117580.html originally reported by Igor.
> >>
> >> "Looks like this is copy paste error from my side,(for port2/3 it should have been bypass
> >>  for port2/3 rather its port1 set in bypass mode)"
> >>
> >> I only submit the patch since it is missing in 2012.04-rc3 while the twister board
> >> depends on it. Maybe it is already somewhere in the reposistory, but I cannot find it.
> >>
> >> note: the twister boards still needs an additional `usb reset`, don't know why.
> > 
> > 
> > I don't see any difference between the first usb start and the following
> > resets, should there have been?  Clearly, there's a problem, but lets
> > see if we can fix all of it in time..  Thanks!
> 
> The issue was raised during the review of Govindraj's patch, it seems
> the wrong version was picked up.
> 
> Acked-by : Stefano Babic <sbabic@denx.de>
> 
> Can you apply it for the release (this is clearly a fix) ?

OK:

Acked-by: Tom Rini <trini@ti.com>

Wolfgang, can you pick this up out of patchwork?  I've assigned it to
you.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120420/d0dfd4ac/attachment.pgp>

  reply	other threads:[~2012-04-20 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-19 21:25 [U-Boot] [PATCH] ehci-omap: fix for enabling the correct usb port Jeroen Hofstee
2012-04-19 22:42 ` Tom Rini
2012-04-20  6:43   ` Jeroen Hofstee
2012-04-20  7:42   ` Stefano Babic
2012-04-20 15:24     ` Tom Rini [this message]
2012-04-20  7:28 ` Govindraj
2012-04-21 15:02 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120420152422.GA23731@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox