From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440
Date: Fri, 20 Apr 2012 18:17:25 +0200 [thread overview]
Message-ID: <201204201817.25124.marex@denx.de> (raw)
In-Reply-To: <CABi8O6Yduf2ezgaXzQ5tLMr_MyZt+UfZPE2DWYc2Xnttg-m=3w@mail.gmail.com>
Dear Ilya Averyanov,
> 2012/4/20 Ilya Averyanov <averyanovin+uboot@gmail.com>
>
> > 2012/4/20 Marek Vasut <marex@denx.de>
> >
> >> Dear Ilya Averyanov,
> >>
> >> > 2012/4/20 Marek Vasut <marex@denx.de>
> >> >
> >> > > Dear Ilya Averyanov,
> >> > >
> >> > > [...]
> >> > >
> >> > > > > > > > > > .word 0x32
> >> > > > > > > > > > + .word 0x30
> >> > > > > > > > > > + .word 0x30
> >> > > > > > > > >
> >> > > > > > > > > What this undocumented stuff?
> >> > > > > > > >
> >> > > > > > > > SoC specific, I pasted it from smdk2410, it's for
> >> > > > > > > > initialize the
> >> > > > >
> >> > > > > DRAM.
> >> > > > >
> >> > > > > > > Can't you init DRAM in some more fitting place? Also
> >> > > > > > > document this?
> >> > > > > >
> >> > > > > > I don't know, this part is a bit difficult for me, but I'm
> >>
> >> going to
> >>
> >> > > try
> >> > >
> >> > > > > > to document it with the help of the SoC documentation.
> >> > > > > >
> >> > > > > > For the place, should I move it to mini2440.c in
> >>
> >> arch_cpu_init() or
> >>
> >> > > > > > board_early_init_f() ? I don't really know the difference.
> >> > > > >
> >> > > > > dram_init() maybe ?
> >> > > >
> >> > > > You propose to initialize the SDRAM controller in dram_init ()?
> >> > >
> >> > > Well yes, ain't it more fitting ?
> >> > >
> >> > > Best regards,
> >> > > Marek Vasut
> >> >
> >> > No. We have to two reasons why this is not the case.
> >> > 1) Open u-boot/arch/arm/cpu/arm920t/start.S:328
> >> > cpu_init_crit
> >> > ......
> >> > line 346
> >> >
> >> > /*
> >> >
> >> > * before relocating, we have to setup RAM timing
> >> > * because memory timing is board-dependend, you will
> >> > * find a lowlevel_init.S in your board directory.
> >> > */
> >>
> >> Well don't setup run in lowlevel_init.S then ?
> >>
> >> > 2) NAND controller must be initialized before C code run.
> >>
> >> Why?
> >>
> >> Best regards,
> >> Marek Vasut
> >
> > mmm...
> > Because we need a stack.
> > The stack is in RAM.
> >
> >2) NAND controller must be initialized before C code run.
>
> Sorry made ??a mistake. SDRAM! Not NAND!
Which doesn't matter, either way you need stack ... and you can have the stack
in cache ;-)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-20 16:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 17:46 [U-Boot] Add support for Mini2440 Gabriel Huau
2012-04-17 20:09 ` [U-Boot] [PATCH V2] " Gabriel Huau
[not found] ` <1334694802-4881-1-git-send-email-contact@huau-gabriel.fr>
2012-04-17 20:45 ` [U-Boot] [PATCH v2] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Marek Vasut
2012-04-19 19:25 ` [U-Boot] [PATCH v3] " Gabriel Huau
2012-04-19 20:08 ` Marek Vasut
2012-04-19 20:16 ` Gabriel Huau
2012-04-19 20:45 ` Marek Vasut
2012-04-19 21:33 ` Gabriel Huau
2012-04-19 22:22 ` Marek Vasut
2012-04-20 7:19 ` Ilya Averyanov
2012-04-20 9:11 ` Marek Vasut
2012-04-20 13:35 ` Ilya Averyanov
2012-04-20 14:08 ` Marek Vasut
2012-04-20 14:30 ` Ilya Averyanov
2012-04-20 14:35 ` Ilya Averyanov
2012-04-20 16:17 ` Marek Vasut [this message]
2012-04-20 17:17 ` Ilya Averyanov
2012-04-20 19:11 ` Marek Vasut
2012-04-23 20:36 ` Wolfgang Denk
2012-04-20 19:18 ` Vasily Khoruzhick
2012-04-20 20:03 ` Marek Vasut
2012-04-20 22:51 ` Ilya Averyanov
2012-04-20 23:07 ` Marek Vasut
2012-04-21 7:35 ` Vasily Khoruzhick
2012-04-23 20:43 ` Wolfgang Denk
2012-04-20 23:30 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440) Gabriel Huau
2012-04-21 4:09 ` Ilya Averyanov
2012-04-21 9:00 ` Vasily Khoruzhick
2012-04-21 7:42 ` [U-Boot] [PATCH v3] Add support for MINI2440 (s3c2440). Documentation about the product can be found on: http://www.friendlyarm.net/products/mini2440 Vasily Khoruzhick
2012-04-21 10:39 ` Marek Vasut
2012-04-21 12:33 ` Ilya Averyanov
2012-04-21 13:19 ` Marek Vasut
2012-04-23 13:40 ` Ilya Averyanov
2012-04-23 14:07 ` Marek Vasut
2012-04-23 14:27 ` Ilya Averyanov
2012-04-23 15:25 ` Marek Vasut
2012-04-23 20:39 ` Wolfgang Denk
2012-04-20 16:16 ` Marek Vasut
2012-04-19 21:37 ` Ilya Averyanov
2012-04-19 22:23 ` Marek Vasut
2012-04-19 22:30 ` Graeme Russ
2012-04-19 22:22 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204201817.25124.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox