public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] 'run' no longer aborts on an error, can someone please verify
Date: Mon, 23 Apr 2012 10:20:05 +0200	[thread overview]
Message-ID: <20120423082005.8497F200261@gemini.denx.de> (raw)
In-Reply-To: <4F932CEC.30808@gmail.com>

Dear Gray Remlin,

In message <4F932CEC.30808@gmail.com> you wrote:
> U-Boot v2012.04
> 
> Marvell>> setenv ipaddr '192.168.1.130'
> Marvell>> setenv ifhostisup 'ping 192.168.1.100'
> Marvell>> setenv saywearehappy 'echo "We are happy!"'
> Marvell>> run ifhostisup saywearehappy;
> Using egiga0 device
> ping failed; host 192.168.1.100 is not alive
> "We are happy!"
> Marvell>> 
> 
> This is not the same behaviour as my (unfortunately customised) version based on the ancient U-Boot 2009.11
> Other commands are also effected, for example 'ide dev 0' would abort a 'run' command if the device did not exist.
> 
> Is this my problem (corrupted source\compilation) or a change in policy ?

I cannot confirm a problem with the "run' command; tested with
v2012.04 in "sandbox" :

------------------------------------
$ echo 'setenv fail printenv foo;setenv bug echo === BUG ===;run fail bug; reset' | ./u-boot


U-Boot 2012.04 (Apr 23 2012 - 10:07:18)

DRAM:  128 MiB
Using default environment

In:    serial
Out:   serial
Err:   serial
=>setenv fail printenv foo;setenv bug echo === BUG ===;run fail bug; reset
## Error: "foo" not defined
$ 
------------------------------------

i. e. the second command ("echo === BUG ===") does not get run.

Ditto on real hardware (here a MPC5200 based board):

------------------------------------
U-Boot 2012.04 (Apr 23 2012 - 10:16:22)

CPU:   MPC5200B v2.2, Core v1.4 at 396 MHz
       Bus 132 MHz, IPB 132 MHz, PCI 66 MHz
...
=> setenv ifhostisup 'ping 192.168.99.99'
=> setenv saywearehappy 'echo "We are happy!"'
=> run ifhostisup saywearehappy
Using FEC device
ping failed; host 192.168.99.99 is not alive
=> 
------------------------------------


Which exact version of U-Boot and which board configuration are you testing?

Are you using hush shell, or plain old command interpreter?

[In both my tests the hush shell was used.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A conservative is a man with two perfectly good legs  who  has  never
learned to walk.                              - Franklin D. Roosevelt

  parent reply	other threads:[~2012-04-23  8:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-21 20:51 [U-Boot] [STATUS] v2012.04 released, Merge Window is OPEN Wolfgang Denk
2012-04-21 21:55 ` [U-Boot] 'run' no longer aborts on an error, can someone please verify Gray Remlin
2012-04-23  5:43   ` Timo Ketola
2012-04-23  7:37     ` Timo Ketola
2012-04-23  8:39       ` Wolfgang Denk
2012-04-23  9:57         ` [U-Boot] [PATCH] Fix the behaviour of the 'run' command Timo Ketola
2012-04-23 10:15           ` Wolfgang Denk
2012-04-23 19:56           ` Simon Glass
2012-04-23 20:07           ` Wolfgang Denk
2012-04-23 11:02     ` [U-Boot] 'run' no longer aborts on an error, can someone please verify Simon Glass
2012-04-23 11:16       ` Wolfgang Denk
2012-04-23 19:04         ` Simon Glass
2012-04-23 20:12         ` Simon Glass
2012-04-23  8:20   ` Wolfgang Denk [this message]
2012-04-23  8:33     ` Timo Ketola
2012-04-23  8:34     ` Wolfgang Denk
2012-04-23 11:00 ` [U-Boot] [STATUS] v2012.04 released, Merge Window is OPEN Albert ARIBAUD
2012-04-23 15:45 ` Stephen Warren
2012-04-23 18:44   ` Dirk Behme
2012-04-23 20:08   ` Wolfgang Denk
2012-04-23 20:16     ` Stephen Warren
2012-04-23 21:03       ` Wolfgang Denk
2012-04-23 20:26     ` Tom Rini
2012-04-23 21:06       ` Wolfgang Denk
2012-04-23 22:38         ` Graeme Russ
2012-04-25 14:02 ` [U-Boot] [STATUS] v2012.04.01 released Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120423082005.8497F200261@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox