public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h
Date: Thu, 26 Apr 2012 11:03:19 +0200	[thread overview]
Message-ID: <20120426110319.3690e103@wker> (raw)
In-Reply-To: <20120425175851.3c996837@lmajewski.digital.local>

Hi Lukasz,

On Wed, 25 Apr 2012 17:58:51 +0200
Lukasz Majewski <l.majewski@samsung.com> wrote:

> Hi Anatolij,
> 
> > From: Mike Frysinger <vapier@gentoo.org>
> > 
> > Merge our duplicate definitions with the common header.
> > Also fix drivers/usb/gadget/s3c_udc_otg_xfer_dma.c to
> > use min() instead of min_t() since we remove the latter
> > from compat.h.
> 
> Yes. the include/usb/lin_gadget_compat.h layer.
> Good idea to provide one compat file (as fair as I remember similar
> problem is with mtd/compat.h).
> 
> I'll look into the include/linux.h file.

Mike already moved mtd/compat.h to linux/compat.h, please see this
patch http://patchwork.ozlabs.org/patch/151500/

Now I see another issue. In this 4/4 patch we are removing kmalloc:

-#define kmalloc(size, type) memalign(CONFIG_SYS_CACHELINE_SIZE, size)

linux/compat.h defines kmalloc() to be malloc(), so the gadget driver
should probably use memalign() directly where it is needed?

Thanks,
Anatolij

  reply	other threads:[~2012-04-26  9:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 23:39 [U-Boot] [PATCH 1/4] gunzip: rename z{alloc, free} to gz{alloc, free} Mike Frysinger
2012-04-09 23:39 ` [U-Boot] [PATCH 2/4] lin_gadget: use common mdelay Mike Frysinger
2012-04-26 12:48   ` Anatolij Gustschin
2012-04-09 23:39 ` [U-Boot] [PATCH 3/4] linux/compat.h: rename from linux/mtd/compat.h Mike Frysinger
2012-04-26 13:03   ` Anatolij Gustschin
2012-04-09 23:39 ` [U-Boot] [PATCH 4/4] lin_gadget: use common linux/compat.h Mike Frysinger
2012-04-25  8:11   ` [U-Boot] [PATCH v2 " Anatolij Gustschin
2012-04-25 15:14     ` Mike Frysinger
2012-04-25 15:58     ` Lukasz Majewski
2012-04-26  9:03       ` Anatolij Gustschin [this message]
2012-04-26 10:32         ` Lukasz Majewski
2012-04-26 10:55           ` Anatolij Gustschin
2012-04-26 12:34     ` [U-Boot] [PATCH v3 " Anatolij Gustschin
2012-04-30 14:51       ` Anatolij Gustschin
2012-04-26 12:47 ` [U-Boot] [PATCH 1/4] gunzip: rename z{alloc, free} to gz{alloc, free} Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120426110319.3690e103@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox