[U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

Lukasz Majewski
2012-04-26T10:32:40Z

Hi Anatolij,

> > Hi Anatolij,
> >
> > > From: Mike Frysinger <vapier@gentoo.org>
> > >
> > > Merge our duplicate definitions with the common header.
> > > Also fix drivers/usb/gadget/s3c_udc_otg_xfer_dma.c to
> > > use min() instead of min_t() since we remove the latter
> > > from compat.h.
> >
> > Yes. the include/usb/lin_gadget_compat.h layer.
> > Good idea to provide one compat file (as fair as I remember similar
> > problem is with mtd/compat.h).
> >
> > I'll look into the include/linux.h file.
>
> Mike already moved mtd/compat.h to linux/compat.h, please see this
> patch http://patchwork.ozlabs.org/patch/151500/
>
> Now I see another issue. In this 4/4 patch we are removing kmalloc:
>
> -#define kmalloc(size, type) memalign(CONFIG_SYS_CACHELINE_SIZE, size)
>
> linux/compat.h defines kmalloc() to be malloc(), so the gadget driver
> should probably use memalign() directly where it is needed?

In the include/usb/lin_gadget_compat.h the

#define kmalloc(size, type) memalign(CONFIG_SYS_CACHELINE_SIZE, size)
line is defined.

I think that memalign can be used directly, no problem.

--
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group